register a terminating pod if containers running

[olyazavr]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When a pod is terminating, but its containers are still running (eg. it's running a prestop hook), and then kubelet restarts, it will re-sync but not the volumes, and that causes this error: MountVolume.SetUp failed for volume \"kube-public-cert\" : object \"browsers-dashboard\"/\"kube-public-cert\" not registered" which can only be resolved by force-deleting the pod

See this gist for logs: https://gist.github.com/olyazavr/f1980620e89dead80e72a23fcfe2014d

Basically we want this logic that happens in SyncPod but in the SyncTerminatingPod flow

Testing: I have a pod with a prestop hook to sleep for 10m, and a secret mounted on it. I kill the pod, then restart kubelet. Without this change, it will error out with the mount volume error, and with it, that error does not appear and the pod terminates gracefully

Which issue(s) this PR fixes:

Fixes #113289

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes a bug where if a pod is terminating and has a secret or configmap mounted and kubelet restarts, it would get MountVolume.SetUp errors and not complete terminating unless force-deleted 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @olyazavr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[olyazavr]

/sig node

[HirazawaUi]

/ok-to-test
I guess we should write an e2e test for it?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olyazavr
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS
• test/e2e_node/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bart0sh]

/triage accepted
/priority important-longterm

[HirazawaUi]

Suggested change

	gomega.Eventually(ctx, func(ctx context.Context) error {
	return verifyPodDisappeared(ctx, f.ClientSet, podName, ns)
	}, 2*time.Minute, time.Second*1).Should(gomega.BeNil())
	gomega.Eventually(ctx, func() bool {
	_, err := cl.CoreV1().Pods(ns).Get(ctx, name, metav1.GetOptions{})
	return apierrors.IsNotFound(err)
	}, 2*time.Minute, time.Second).Should(gomega.BeTrue())

It'll be easier.

[HirazawaUi]

I think it should move to test/e2e_node/terminate_pods_test.go

[olyazavr]

/retest