Skip to content

Commit

Permalink
Merge pull request #14166 from sharifelgamal/double-iso
Browse files Browse the repository at this point in the history
fix release jobs to account for two ISOs
  • Loading branch information
spowelljr committed May 13, 2022
2 parents 1f195e1 + e03c192 commit 51ba46c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,8 @@ mdlint:

.PHONY: verify-iso
verify-iso: # Make sure the current ISO exists in the expected bucket
gsutil stat gs://$(ISO_BUCKET)/minikube-$(ISO_VERSION).iso
gsutil stat gs://$(ISO_BUCKET)/minikube-$(ISO_VERSION)-amd64.iso
gsutil stat gs://$(ISO_BUCKET)/minikube-$(ISO_VERSION)-arm64.iso

out/docs/minikube.md: $(shell find "cmd") $(shell find "pkg/minikube/constants")
go run -ldflags="$(MINIKUBE_LDFLAGS)" -tags gendocs hack/help_text/gen_help_text.go
Expand Down
6 changes: 4 additions & 2 deletions hack/jenkins/release_github_page.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
# VERSION_MAJOR: The major version of the tag to be released.
# VERSION_MINOR: The minor version of the tag to be released.
# VERSION_BUILD: The build version of the tag to be released.
# ISO_SHA256: The sha 256 of the minikube-iso for the current release.
# ISO_SHA256_AMD64: The sha 256 of the amd64 minikube-iso for the current release.
# ISO_SHA256_ARM64: The sha 256 of the arm64 minikube-iso for the current release.
# GITHUB_TOKEN: The GitHub API access token. Injected by the Jenkins credential provider.

set -eux -o pipefail
Expand Down Expand Up @@ -62,7 +63,8 @@ See [Getting Started](https://minikube.sigs.k8s.io/docs/start/)
## ISO Checksum
\`${ISO_SHA256}\`"
amd64: \`${ISO_SHA256_AMD64}\`
arm64: \`${ISO_SHA256_ARM64}\`"

# ================================================================================
# Deleting release from github before creating new one
Expand Down

0 comments on commit 51ba46c

Please sign in to comment.