-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: QEMU: Add configuration fields for program, cpu type, and machine type #18906
base: master
Are you sure you want to change the base?
Conversation
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d30900f
to
54d59b8
Compare
if cmd.Flags().Changed(qemuCPUType) && viper.GetString(qemuCPUType) != existing.QEMUCPUType { | ||
out.WarningT("You cannot change the QEMU CPU type of an existing minikube cluster. Please first delete the cluster.") | ||
} | ||
|
||
if cmd.Flags().Changed(qemuMachineType) && viper.GetString(qemuMachineType) != existing.QEMUMachineType { | ||
out.WarningT("You cannot change the QEMU machine type of an existing minikube cluster. Please first delete the cluster.") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe QEMU program should also not be allowed to be changed on an existing cluster?
This comment has been minimized.
This comment has been minimized.
kvm2 driver with docker runtime
Times for minikube start: 50.5s 49.5s 47.0s 49.5s 50.8s Times for minikube ingress: 27.0s 27.4s 29.0s 27.0s 28.5s docker driver with docker runtime
Times for minikube start: 25.0s 23.5s 24.3s 20.8s 24.5s Times for minikube ingress: 20.8s 21.8s 22.3s 21.8s 22.8s docker driver with containerd runtime
Times for minikube start: 20.2s 23.5s 22.9s 24.5s 23.0s Times for minikube ingress: 31.8s 32.2s 31.8s 31.8s 30.8s |
This comment has been minimized.
This comment has been minimized.
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
@@ -208,6 +211,9 @@ func initMinikubeFlags() { | |||
startCmd.Flags().String(staticIP, "", "Set a static IP for the minikube cluster, the IP must be: private, IPv4, and the last octet must be between 2 and 254, for example 192.168.200.200 (Docker and Podman drivers only)") | |||
startCmd.Flags().StringP(gpus, "g", "", "Allow pods to use your NVIDIA GPUs. Options include: [all,nvidia] (Docker driver with Docker container-runtime only)") | |||
startCmd.Flags().Duration(autoPauseInterval, time.Minute*1, "Duration of inactivity before the minikube VM is paused (default 1m0s)") | |||
startCmd.Flags().String(qemuProgram, "", "The program used to start QEMU. If left empty automatically decides.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it automatically "decide" or does it use the default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It chooses a value depending on the machine architecture
@@ -109,6 +109,9 @@ type ClusterConfig struct { | |||
SSHAgentPID int | |||
GPUs string | |||
AutoPauseInterval time.Duration // Specifies interval of time to wait before checking if cluster should be paused | |||
QEMUProgram string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should log to the UI that you are using a Custom Qemu program, this will help us when the users come with issues using custom qemu programs that are not supporting or testing and only available for them to use for on their own support
Implements: #18895