WIP: QEMU: Add configuration fields for program, cpu type, and machine type #18906

spowelljr · 2024-05-15T18:01:03Z

Implements: #18895

spowelljr · 2024-05-15T18:01:11Z

/ok-to-test

k8s-ci-robot · 2024-05-15T18:01:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spowelljr · 2024-05-15T18:17:05Z

cmd/minikube/cmd/start_flags.go

+	if cmd.Flags().Changed(qemuCPUType) && viper.GetString(qemuCPUType) != existing.QEMUCPUType {
+		out.WarningT("You cannot change the QEMU CPU type of an existing minikube cluster. Please first delete the cluster.")
+	}
+
+	if cmd.Flags().Changed(qemuMachineType) && viper.GetString(qemuMachineType) != existing.QEMUMachineType {
+		out.WarningT("You cannot change the QEMU machine type of an existing minikube cluster. Please first delete the cluster.")
+	}


Maybe QEMU program should also not be allowed to be changed on an existing cluster?

minikube-pr-bot · 2024-05-15T19:27:23Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18906) |
+----------------+----------+---------------------+
| minikube start | 49.5s    | 49.2s               |
| enable ingress | 27.8s    | 25.8s               |
+----------------+----------+---------------------+

Times for minikube start: 50.5s 49.5s 47.0s 49.5s 50.8s
Times for minikube (PR 18906) start: 46.2s 50.9s 50.5s 47.5s 50.7s

Times for minikube ingress: 27.0s 27.4s 29.0s 27.0s 28.5s
Times for minikube (PR 18906) ingress: 23.4s 23.9s 27.9s 28.0s 25.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18906) |
+----------------+----------+---------------------+
| minikube start | 23.6s    | 22.7s               |
| enable ingress | 21.9s    | 22.0s               |
+----------------+----------+---------------------+

Times for minikube start: 25.0s 23.5s 24.3s 20.8s 24.5s
Times for minikube (PR 18906) start: 23.3s 21.5s 23.6s 21.4s 23.7s

Times for minikube ingress: 20.8s 21.8s 22.3s 21.8s 22.8s
Times for minikube (PR 18906) ingress: 22.8s 21.8s 21.8s 21.8s 21.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18906) |
+----------------+----------+---------------------+
| minikube start | 22.8s    | 20.9s               |
| enable ingress | 31.7s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube start: 20.2s 23.5s 22.9s 24.5s 23.0s
Times for minikube (PR 18906) start: 20.3s 22.8s 19.9s 22.3s 19.3s

Times for minikube ingress: 31.8s 32.2s 31.8s 31.8s 30.8s
Times for minikube (PR 18906) ingress: 32.3s 31.8s 30.8s 32.8s 32.3s

minikube-pr-bot · 2024-05-16T04:11:08Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestAddons/parallel/HelmTiller (gopogh)	1.97 (chart)
QEMU_macOS	TestFunctional/parallel/CpCmd (gopogh)	13.59 (chart)
QEMU_macOS	TestFunctional/parallel/FileSync (gopogh)	13.59 (chart)
QEMU_macOS	TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh)	13.59 (chart)
QEMU_macOS	TestFunctional/parallel/SSHCmd (gopogh)	13.59 (chart)
QEMU_macOS	TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh)	13.59 (chart)
QEMU_macOS	TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh)	13.59 (chart)
QEMU_macOS	TestFunctional/parallel/Version/components (gopogh)	13.59 (chart)
QEMU_macOS	TestFunctional/serial/LogsCmd (gopogh)	13.59 (chart)
QEMU_macOS	TestFunctional/serial/LogsFileCmd (gopogh)	13.59 (chart)
QEMU_macOS	TestMultiControlPlane/serial/NodeLabels (gopogh)	13.59 (chart)
QEMU_macOS	TestAddons/Setup (gopogh)	14.56 (chart)
QEMU_macOS	TestMultiControlPlane/serial/HAppyAfterClusterStart (gopogh)	14.56 (chart)
QEMU_macOS	TestMultiControlPlane/serial/HAppyAfterSecondaryNodeRestart (gopogh)	14.56 (chart)
QEMU_macOS	TestFunctional/parallel/CertSync (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/DockerEnv/bash (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageListJson (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageListShort (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageListTable (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/NodeLabels (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	15.53 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/DeployApp (gopogh)	15.53 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

medyagh · 2024-05-16T16:38:52Z

cmd/minikube/cmd/start_flags.go

@@ -208,6 +211,9 @@ func initMinikubeFlags() {
 	startCmd.Flags().String(staticIP, "", "Set a static IP for the minikube cluster, the IP must be: private, IPv4, and the last octet must be between 2 and 254, for example 192.168.200.200 (Docker and Podman drivers only)")
 	startCmd.Flags().StringP(gpus, "g", "", "Allow pods to use your NVIDIA GPUs. Options include: [all,nvidia] (Docker driver with Docker container-runtime only)")
 	startCmd.Flags().Duration(autoPauseInterval, time.Minute*1, "Duration of inactivity before the minikube VM is paused (default 1m0s)")
+	startCmd.Flags().String(qemuProgram, "", "The program used to start QEMU. If left empty automatically decides.")


does it automatically "decide" or does it use the default value?

It chooses a value depending on the machine architecture

medyagh · 2024-05-20T18:17:54Z

pkg/minikube/config/types.go

@@ -109,6 +109,9 @@ type ClusterConfig struct {
 	SSHAgentPID             int
 	GPUs                    string
 	AutoPauseInterval       time.Duration // Specifies interval of time to wait before checking if cluster should be paused
+	QEMUProgram             string


we should log to the UI that you are using a Custom Qemu program, this will help us when the users come with issues using custom qemu programs that are not supporting or testing and only available for them to use for on their own support

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024

spowelljr mentioned this pull request May 15, 2024

How Do You Set the QEMU Driver Flags From Minikube #18895

Open

k8s-ci-robot requested review from afbjorklund and prezha May 15, 2024 18:01

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024

QEMU: Add configuration fields for program, cpu type, and machine type

54d59b8

spowelljr force-pushed the addQEMUConfiguration branch from d30900f to 54d59b8 Compare May 15, 2024 18:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: QEMU: Add configuration fields for program, cpu type, and machine type #18906

WIP: QEMU: Add configuration fields for program, cpu type, and machine type #18906

spowelljr commented May 15, 2024 •

edited

spowelljr commented May 15, 2024

k8s-ci-robot commented May 15, 2024

spowelljr May 15, 2024

This comment has been minimized.

minikube-pr-bot commented May 15, 2024

This comment has been minimized.

minikube-pr-bot commented May 16, 2024

medyagh May 16, 2024

spowelljr May 16, 2024

medyagh May 20, 2024

WIP: QEMU: Add configuration fields for program, cpu type, and machine type #18906

Are you sure you want to change the base?

WIP: QEMU: Add configuration fields for program, cpu type, and machine type #18906

Conversation

spowelljr commented May 15, 2024 • edited

spowelljr commented May 15, 2024

k8s-ci-robot commented May 15, 2024

spowelljr May 15, 2024

Choose a reason for hiding this comment

This comment has been minimized.

minikube-pr-bot commented May 15, 2024

This comment has been minimized.

minikube-pr-bot commented May 16, 2024

medyagh May 16, 2024

Choose a reason for hiding this comment

spowelljr May 16, 2024

Choose a reason for hiding this comment

medyagh May 20, 2024

Choose a reason for hiding this comment

spowelljr commented May 15, 2024 •

edited