Clean up the nerdctld installation #18530
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
afbjorklund
changed the title
k8s-ci-robot
added
size/M
afbjorklund
force-pushed
the
nerdctld-cleanup
branch
from
da4226f
to
2774a70
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
afbjorklund
force-pushed
the
nerdctld-cleanup
branch
from
2774a70
to
14aba6d
Compare
|
/cc ComradeProgrammer |
|
@afbjorklund: GitHub didn't allow me to request PR reviews from the following users: ComradeProgrammer. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This comment has been minimized.
This comment has been minimized.
|
@afbjorklund doesnt this need to edit the ISO also ? |
|
/ok-to-build-image |
nerdctld isn't installed in the ISO (yet) |
|
Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
This comment has been minimized.
This comment has been minimized.
k8s-ci-robot
added
the
needs-rebase
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I think the changes are good (and I actually learnt a lot), but currently I still cannot press the 'approve' button. I will have a try when the conflicts are solved. |
|
@afbjorklund is it possible that you rebase the PR ? otherwise looks good to merge |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use the regular upstream names for socket and service. Don't use world-writable permissions for the binaries. The socket starts the service when it is activated. The units go in the installation and not in config.
spowelljr
force-pushed
the
nerdctld-cleanup
branch
from
fb30ac3
to
ca0e80d
Compare
k8s-ci-robot
removed
the
needs-rebase
spowelljr
added
needs-ok-to-test
|
ok-to-build-image |
|
Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 driver with docker runtime Times for minikube start: 52.0s 55.9s 51.8s 54.0s 52.1s Times for minikube ingress: 23.6s 27.5s 23.6s 27.6s 27.6s docker driver with docker runtime Times for minikube start: 24.2s 24.3s 22.9s 24.2s 22.5s Times for minikube ingress: 19.8s 21.3s 21.3s 21.3s 21.3s docker driver with containerd runtime Times for minikube start: 23.5s 21.4s 20.5s 21.1s 19.9s Times for minikube ingress: 31.9s 31.8s 48.8s 31.8s 32.8s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
Docker Linux containerd docker-env tests are failing Seems to be a weird URL?
|
spowelljr
added
the
do-not-merge/failing-test
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Use the regular upstream names for socket and service.
Don't use world-writable permissions for the binaries.
The socket starts the service when it is activated.
The units go in the installation and not in config.
Cleanup from
508adea