-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cosmetic bug with note shortcode #46389
Fix cosmetic bug with note shortcode #46389
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Preview looks great! Thanks for tackling this! /lgtm |
LGTM label has been added. Git tree hash: 134ff3780fe6ab54b0ed0d5b97002101a281d125
|
assets/scss/_custom.scss
Outdated
line-height: 0 !important; | ||
} | ||
|
||
.alert-info:has(h4):has(ul) ul { | ||
margin-top: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try this:
line-height: 0 !important; | |
} | |
.alert-info:has(h4):has(ul) ul { | |
margin-top: 10px; | |
float: initial; | |
line-height: inherit; | |
margin-bottom: 1rem; |
Oops, no, wrong suggestion. Actually I like it again. Give it a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim
it looks good if only add [float: initial !important;]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim
committed new changes please review it.
assets/scss/_custom.scss
Outdated
@@ -530,6 +530,10 @@ body { | |||
border-left-color: #444; | |||
} | |||
|
|||
.alert-info:has(h4):has(ul) h4 { | |||
float: initial !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a more specific selector to avoid the need for !important
?
/lgtm
but I'd prefer not to use !important
here.
LGTM label has been added. Git tree hash: f277c485645893e081384e2f0b60b8f1edc3eefe
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Potential for improvement post merge (Refer review comment (here))
Edit: This will need official approval from sig-docs-website-owner
/approve
@sftim |
I confirm this is updated. It will need approval from the website approvers team. /retitle Fix cosmetic bug with note shortcode |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: a07023f07acb049ea0608c145c09bb12f6224567
|
Amazing, thanks all |
Fixes #46371