Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cosmetic bug with note shortcode #46389

Merged
merged 3 commits into from
May 28, 2024
Merged

Fix cosmetic bug with note shortcode #46389

merged 3 commits into from
May 28, 2024

Conversation

tamilselvan1102
Copy link
Contributor

Fixes #46371

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim May 15, 2024 09:11
@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label May 15, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tengqm May 15, 2024 09:11
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 15, 2024
@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6f0159b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/664c38521e8325000827a1f3
😎 Deploy Preview https://deploy-preview-46389--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tamilselvan1102
Copy link
Contributor Author

preview : https://deploy-preview-46389--kubernetes-io-main-staging.netlify.app/docs/concepts/policy/resource-quotas/

@salaxander
Copy link
Contributor

Preview looks great! Thanks for tackling this!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 134ff3780fe6ab54b0ed0d5b97002101a281d125

sftim
sftim reviewed May 15, 2024
View reviewed changes
assets/scss/_custom.scss Outdated
Comment on lines 534 to 538
line-height: 0 !important;
}

.alert-info:has(h4):has(ul) ul {
margin-top: 10px;
Copy link
Contributor

@sftim sftim May 15, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this:

Suggested change
line-height: 0 !important;
}
.alert-info:has(h4):has(ul) ul {
margin-top: 10px;
float: initial;
line-height: inherit;
margin-bottom: 1rem;

Oops, no, wrong suggestion. Actually I like it again. Give it a try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim
it looks good if only add [float: initial !important;]

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim
committed new changes please review it.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
sftim
sftim reviewed May 17, 2024
View reviewed changes
assets/scss/_custom.scss Outdated
@@ -530,6 +530,10 @@ body {
border-left-color: #444;
}

.alert-info:has(h4):has(ul) h4 {
float: initial !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a more specific selector to avoid the need for !important?

/lgtm
but I'd prefer not to use !important here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f277c485645893e081384e2f0b60b8f1edc3eefe

dipesh-rawat
dipesh-rawat reviewed May 19, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Potential for improvement post merge (Refer review comment (here))

Edit: This will need official approval from sig-docs-website-owner

/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim May 21, 2024 05:59
@tamilselvan1102
Copy link
Contributor Author

@sftim
updated existing style. please confirm

@sftim
Copy link
Contributor

sftim commented May 28, 2024

@sftim updated existing style. please confirm

I confirm this is updated. It will need approval from the website approvers team.

/retitle Fix cosmetic bug with note shortcode
/approve

@k8s-ci-robot k8s-ci-robot changed the title Update bullet point style Fix cosmetic bug with note shortcode May 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@sftim
Copy link
Contributor

sftim commented May 28, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a07023f07acb049ea0608c145c09bb12f6224567

@k8s-ci-robot k8s-ci-robot merged commit f5f2aeb into kubernetes:main May 28, 2024
6 checks passed
@spurin
Copy link
Contributor

spurin commented May 28, 2024

Amazing, thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@tengqm tengqm Awaiting requested review from tengqm

@salaxander salaxander Awaiting requested review from salaxander

@sftim sftim Awaiting requested review from sftim

Assignees

@salaxander salaxander

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notes that begin with a bullet appear malformed
6 participants
@tamilselvan1102 @salaxander @k8s-ci-robot @sftim @spurin @dipesh-rawat