Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nl] Update list of versions to match English #46357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ricardoamaro
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

@ricardoamaro: The label(s) language/nl cannot be applied, because the repository doesn't have them.

In response to this:

Align https://kubernetes.io/es/docs/home/supported-doc-versions/ with https://kubernetes.io/docs/home/supported-doc-versions/

/language nl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
Copy link

netlify bot commented May 13, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 608b937
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66422a74a6a5af000806b8ed
😎 Deploy Preview https://deploy-preview-46357--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ricardoamaro ricardoamaro marked this pull request as ready for review May 13, 2024 15:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
@salaxander
Copy link
Contributor

/area localization

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label May 13, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting! I wasn't aware that we have Dutch (ISO 639-1 code nl) localization support. Perhaps this is similar to what was done for the Norwegian language, possibly added for only testing purposes. I'll defer to the Localization or Docs leads to provide more insight on this.

@seokho-son
Copy link
Member

seokho-son commented May 14, 2024

Hi @dipesh-rawat,

  • We currently do not have Dutch localization support (ISO 639-1 code: nl).
  • Our only Dutch localization file is data/i18n/nl/nl.toml, which was added 5 years ago through this PR: Created nl.toml #14131. This was before we had a formalized localization guide.
  • We have two options: we can either remove data/i18n/nl/nl.toml since it is not maintained by a localization team, or we can continue to maintain data/i18n/nl/nl.toml with contributions from individual contributors.

While this PR is acceptable since the update does not affect our live site, I believe it would be better to remove data/i18n/nl/nl.toml since it has not been updated in the last 4 years (apart from being relocated and minor typo fix).
(note: https://github.com/kubernetes/website/blob/main/i18n/nl.toml should be cared as well if we remove the content)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants