Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no] Update list of versions to match English #46358

Closed
wants to merge 1 commit into from

Conversation

ricardoamaro
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/no Issues or PRs related to Norwegian language labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 13, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2024
@ricardoamaro ricardoamaro marked this pull request as ready for review May 13, 2024 15:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
Copy link

netlify bot commented May 13, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d81cd6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66422cca70f56d0008c544e0
😎 Deploy Preview https://deploy-preview-46358--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@salaxander
Copy link
Contributor

/area localization

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label May 13, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, the Norwegian language was included for testing purposes (As seen in this commit: 1b5ff98). However, it is currently inactive and disabled in hugo.toml, with no designated formal reviewers or approvers. Additionally, please note that localization leads are planning to remove this test language content soon. Given this information, it seems appropriate to proceed with closing this PR.

@ricardoamaro
Copy link
Contributor Author

Sounds good!

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this PR (Refer #46358 (review) #46358 (comment))

/close

@k8s-ci-robot
Copy link
Contributor

@dipesh-rawat: Closed this PR.

In response to this:

Closing this PR (Refer #46358 (review) #46358 (comment))

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/no Issues or PRs related to Norwegian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants