-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated examples about ConfigMaps as volume mounts #46364
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm |
LGTM label has been added. Git tree hash: e9c2d5897358757849a775ea36e467bb131e4e3b
|
Hi @pegasas, thanks for opening this PR. However, both examples are valid. Passing the config map as an environmental variable makes the configuration available as an environmental variable, so when you execute |
Hi, @network-charles , |
I don't quite understand your reply. Are you saying my comment is valid and the PR needs to be closed? |
I think yes it is, this PR is ready for merge. https://kubernetes.io/docs/concepts/configuration/configmap/#configmaps-and-pods So that indeed,we can directly delete other redundant example on this page. |
fix: #45847