fix: logic in baseline calcs

laresbernardo · May 13, 2024 · da7acfe · da7acfe
1 parent 0483f49
commit da7acfe
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/R/robyn.R b/R/robyn.R
@@ -258,9 +258,10 @@ robyn_modelselector <- function(
     group_by(.data$solID) %>%
     mutate(baseline = .data$contribution / sum(.data$contribution)) %>% ungroup() %>%
     filter(.data$rn == "baseline") %>%
-    mutate(baseline_dist = abs(1 - abs(.data$baseline - baseline_ref) / abs(.data$baseline))) %>%
-    arrange(.data$baseline_dist) %>%
-    select(c("solID", "baseline", "baseline_dist"))
+    arrange(abs(.data$baseline)) %>%
+    mutate(baseline_dist = 1 - normalize(abs(baseline_ref - .data$baseline))) %>%
+    select(c("solID", "baseline", "baseline_dist")) %>%
+    arrange(desc(.data$baseline_dist))
 
   # Gather everything up
   dfa <- OutputCollect$allPareto$resultHypParam %>%