Upgrade to MSW 2.0 #1380
Open
Upgrade to MSW 2.0 #1380
+184
−1,602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
requested review from
marcbouchenoire,
nvie,
ofoucherot and
FlowFlorent
as code owners
kettanaito
commented
Jan 6, 2024
| @@ -40,7 +40,7 @@ | |||
| "@liveblocks/jest-config": "*", | |||
| "@types/ws": "^8.5.3", | |||
| "dotenv": "^16.0.3", | |||
| "msw": "^0.39.1", | |||
| "msw": "^2.0.12", | |||
There was a problem hiding this comment.
MSW doesn't seem to be used in @liveblocks/client package but I updated it here anyway. I leave it to you to decide whether to remove it or not.
kettanaito
commented
Jan 6, 2024
| return res( | ||
| ctx.json({ token: legacyTokens[requestCount++ % legacyTokens.length] }) | ||
| ); | ||
| http.post("/mocked-api/legacy-auth", () => { |
There was a problem hiding this comment.
The changes are rather minimal but they bring your tests much closer to the platform. If you are curious, read about the 2.0 release.
|
Please let me know if there are any issues with the tests. The Vercel checks won't start since I'm not a team member (that's fine), and the GitHub Actions seems to be awaiting something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Maintainers
Description
This updates the
mswpackage across the entire Liveblocks monorepo to be of the latest version (2.0.12 at the moment).Thank you for using MSW! It means a lot to me. If you have a chance, please consider supporting the project on GitHub.
How to test it
Related issue(s)
Not related to any issues.