Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also run tests for @liveblocks/yjs on CI #1609

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Also run tests for @liveblocks/yjs on CI #1609

wants to merge 3 commits into from

Conversation

nvie
Copy link
Collaborator

@nvie nvie commented May 13, 2024

Somehow we forgot to add this to the CI test runs.

@nvie nvie self-assigned this May 13, 2024
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-nextjs-comments-audio ⬜️ Ignored (Inspect) May 13, 2024 9:28am
examples-nextjs-comments-canvas ⬜️ Ignored (Inspect) May 13, 2024 9:28am
examples-nextjs-comments-notifications ⬜️ Ignored (Inspect) May 13, 2024 9:28am

Copy link

vercel bot commented May 13, 2024

Deployment failed with the following error:

Too many requests - try again in 1 minute (more than 60, code: "api-deployments-flood").

@nvie
Copy link
Collaborator Author

nvie commented May 13, 2024

@jrowny @nimeshnayaju This morning, I noticed we have never been running the @liveblocks/yjs unit tests on CI. This PR enables that, but for some reason the client isn't sending the ROOM_STATE message (which is expected when using the v7 protocol), or maybe there is something wrong with the mock setup here, because the tests are failing. (I didn't dig deeper here yet, just opened this PR as a reminder to get this fixed.)

@nvie nvie marked this pull request as ready for review May 13, 2024 09:40
@nvie nvie requested review from jrowny and nimeshnayaju May 13, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant