[NVPTX] fixup support for over-aligned parameters #92457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artem-B
approved these changes
May 16, 2024
| bool getAlign(const Function &F, unsigned index, unsigned &align) { | ||
| MaybeAlign getAlign(const Function &F, unsigned Index) { | ||
| // First check the alignstack metadata | ||
| if (MaybeAlign AlignStack = |
There was a problem hiding this comment.
Nit: In some places you're using StackAligh, in others AlignStack. It might be good to settle on one variant when we're dealing with the same info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the NVPTX support for over-aligned parameters and return values in a few related ways:
alignstackattribute, as an alternative to legacy nvvm!"align"metadata entries. While we still maintain the legacy support, long term it might be nice to auto-upgrade toalignstack.ptxas.