Added PL translation for Shortcut settings pane #1861
Conversation
MarcinOrlowski
requested review from
BFH-ktt1,
davidhutchens,
maehne and
zdimension
as code owners
MarcinOrlowski
changed the title
src/main/resources/resources/logisim/strings/gui/gui.properties
Outdated
Show resolved
Hide resolved
| hotkeySimTickHalf = Manual tick half cycle | ||
| hotkeySimTickFull = Manual tick full cycle |
There was a problem hiding this comment.
Shouldn't it be "Manually tick..."?
@davidhutchens: Could you maybe comment on this?
There was a problem hiding this comment.
Now that you point it out, it does seem slightly off. I would actually delete "Manual" and just write "Tick half cycle" and "Tick full cycle". Manual(ly) provides no additional information.
But note that "Manual Tick Half Cycle" is the name of the menu item. So either way, we should be consistent. I might just leave the PR as is. The labels in the panel all begin with uppercase and follow with lowercase. The menu items start each word with uppercase. I don't think the case difference matters, but I wouldn't use different words.
| hotkeyDirNorth = ↑ North | ||
| hotkeyDirSouth = ↓ South | ||
| hotkeyDirEast = → East | ||
| hotkeyDirWest = ← West |
There was a problem hiding this comment.
I'm not sure if adding the arrows is beneficial.
↑ North
← West ↓ South → East
is IMO not better than
North
West South East
If we decide that we like the arrows, we should consider moving → to the right of East (East →)
No description provided.