Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to Java 21. #2004

Merged
merged 3 commits into from
May 20, 2024
Merged

Update README to Java 21. #2004

merged 3 commits into from
May 20, 2024

Conversation

davidhutchens
Copy link
Member

I used grep to find all 16s in docs but missed the README. Thank you for catching it, @maehne.

maehne
maehne previously approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@maehne maehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We should maybe consider changing the JDK download URL.

@BFH-ktt1: What do you think?

README.md Outdated Show resolved Hide resolved
@davidhutchens davidhutchens requested a review from maehne May 16, 2024 18:03
@BFH-ktt1 BFH-ktt1 merged commit 07abe14 into logisim-evolution:main May 20, 2024
10 checks passed
@davidhutchens davidhutchens deleted the docs branch May 20, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maehne maehne maehne approved these changes

@BFH-ktt1 BFH-ktt1 Awaiting requested review from BFH-ktt1 BFH-ktt1 is a code owner

@MarcinOrlowski MarcinOrlowski Awaiting requested review from MarcinOrlowski MarcinOrlowski is a code owner

@zdimension zdimension Awaiting requested review from zdimension zdimension is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidhutchens @maehne @BFH-ktt1