New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure asset and page titles are correctly shown in ckeditor #13678
base: 5.x
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13678 +/- ##
============================================
- Coverage 61.50% 61.30% -0.21%
+ Complexity 34067 34005 -62
============================================
Files 2241 2238 -3
Lines 101850 101650 -200
============================================
- Hits 62647 62315 -332
- Misses 39203 39335 +132 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described, fixes the bug. Thanks :)
Description:
Fixes #13676
sidenote
This whole logic looks weird for multiple reasons, and should be reworked in M6 to remove a lot of unneeded code and logic:
a:
prefix is unused, it's just stripped without taking it into accountSteps to test this PR:
see #13676