Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner initialization of shared structures in ParMesh #4240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

najlkin
Copy link
Contributor

@najlkin najlkin commented Apr 9, 2024

This PR was separated from #4128 . It moves the initialization of the structures for shared edges (sedge_ledge, sface_lface) through FinalizeParTopo() from Finalize() directly to the methods allocating these structures, which were leaving them uninitialized before. This makes the code cleaner, better maintainable and less prone to bugs 馃槈 . However, it poses a slight risk if someone uses in a very-nonstandard way or overrides the protected methods and Finalize directly. This also avoids double update of these structures in Load() unless necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant