Cleaner initialization of shared structures in ParMesh #4240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was separated from #4128 . It moves the initialization of the structures for shared edges (
sedge_ledge
,sface_lface
) throughFinalizeParTopo()
fromFinalize()
directly to the methods allocating these structures, which were leaving them uninitialized before. This makes the code cleaner, better maintainable and less prone to bugs 馃槈 . However, it poses a slight risk if someone uses in a very-nonstandard way or overrides the protected methods andFinalize
directly. This also avoids double update of these structures inLoad()
unless necessary.