Python: implement filters #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
dmytrostruk
reviewed
Mar 27, 2024
python/samples/kernel-syntax-examples/azure_chat_gpt_api_with_hooks.py
Outdated
Show resolved
Hide resolved
python/samples/kernel-syntax-examples/azure_chat_gpt_api_with_hooks.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/hooks/contexts/kernel_hook_context_base.py
Outdated
Show resolved
Hide resolved
Python 3.8 Test Coverage Report •
Python 3.8 Unit Test Overview
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
dmytrostruk
reviewed
Mar 28, 2024
moonbox3
reviewed
Mar 29, 2024
eavanvalkenburg
force-pushed
the
hooks
branch
2 times, most recently
from
a6f6990
to
02a8e65
Compare
juliomenendez
previously requested changes
Apr 4, 2024
python/semantic_kernel/functions/kernel_function_from_prompt.py
Outdated
Show resolved
Hide resolved
eavanvalkenburg
force-pushed
the
hooks
branch
3 times, most recently
from
14cd9fd
to
817fba8
Compare
alliscode
approved these changes
May 17, 2024
moonbox3
approved these changes
May 17, 2024
moonbox3
dismissed
juliomenendez’s stale review
We have 2 approvals, moving forward as-is.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alliscode
approved these changes
May 17, 2024
moonbox3
approved these changes
May 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 17, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This pull request includes significant changes across multiple files, mainly related to the addition of hooks and the modification of function invocations in the `semantic_kernel` module. The changes also include the addition of a new sample and a YAML file, and modifications to the `__init__.py` files. Removals: * [`python/semantic_kernel/events`](diffhunk://#diff-ebda9504832b19ab83239a92c9a6d5f8c744deff9fef86071c13956ec92bb010L1-L11): Removed the previously used events. New Exceptions: * [`python/semantic_kernel/exceptions/kernel_exceptions.py`](diffhunk://#diff-450aaa5595a8b22cd6ee212eb79b7d6b0d4e9c1072063ef32018a3e7d3fdf21dR41-R48): Added new exception classes `OperationCancelledException` and `HookInvalidSignatureError`. [[1]](diffhunk://#diff-450aaa5595a8b22cd6ee212eb79b7d6b0d4e9c1072063ef32018a3e7d3fdf21dR41-R48) [[2]](diffhunk://#diff-450aaa5595a8b22cd6ee212eb79b7d6b0d4e9c1072063ef32018a3e7d3fdf21dR57-R58) Fixes: #3038 Fixes: #6276 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alliscode
approved these changes
May 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alliscode
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This pull request includes significant changes across multiple files, mainly related to the addition of hooks and the modification of function invocations in the
semantic_kernelmodule. The changes also include the addition of a new sample and a YAML file, and modifications to the__init__.pyfiles.Removals:
python/semantic_kernel/events: Removed the previously used events.New Exceptions:
python/semantic_kernel/exceptions/kernel_exceptions.py: Added new exception classesOperationCancelledExceptionandHookInvalidSignatureError. [1] [2]Fixes: #3038
Fixes: #6276
Contribution Checklist