-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: implement filters #5681
Conversation
python/samples/kernel-syntax-examples/azure_chat_gpt_api_with_hooks.py
Outdated
Show resolved
Hide resolved
python/samples/kernel-syntax-examples/azure_chat_gpt_api_with_hooks.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/hooks/contexts/kernel_hook_context_base.py
Outdated
Show resolved
Hide resolved
Python 3.8 Test Coverage Report •
Python 3.8 Unit Test Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been staring at this draft PR for a while, and I like the direction we're heading.
a6f6990
to
02a8e65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just a couple of comments.
python/semantic_kernel/functions/kernel_function_from_prompt.py
Outdated
Show resolved
Hide resolved
14cd9fd
to
817fba8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!
We have 2 approvals, moving forward as-is.
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This pull request includes significant changes across multiple files, mainly related to the addition of hooks and the modification of function invocations in the `semantic_kernel` module. The changes also include the addition of a new sample and a YAML file, and modifications to the `__init__.py` files. Removals: * [`python/semantic_kernel/events`](diffhunk://#diff-ebda9504832b19ab83239a92c9a6d5f8c744deff9fef86071c13956ec92bb010L1-L11): Removed the previously used events. New Exceptions: * [`python/semantic_kernel/exceptions/kernel_exceptions.py`](diffhunk://#diff-450aaa5595a8b22cd6ee212eb79b7d6b0d4e9c1072063ef32018a3e7d3fdf21dR41-R48): Added new exception classes `OperationCancelledException` and `HookInvalidSignatureError`. [[1]](diffhunk://#diff-450aaa5595a8b22cd6ee212eb79b7d6b0d4e9c1072063ef32018a3e7d3fdf21dR41-R48) [[2]](diffhunk://#diff-450aaa5595a8b22cd6ee212eb79b7d6b0d4e9c1072063ef32018a3e7d3fdf21dR57-R58) Fixes: #3038 Fixes: #6276 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Motivation and Context
This pull request includes significant changes across multiple files, mainly related to the addition of hooks and the modification of function invocations in the
semantic_kernel
module. The changes also include the addition of a new sample and a YAML file, and modifications to the__init__.py
files.Removals:
python/semantic_kernel/events
: Removed the previously used events.New Exceptions:
python/semantic_kernel/exceptions/kernel_exceptions.py
: Added new exception classesOperationCancelledException
andHookInvalidSignatureError
. [1] [2]Fixes: #3038
Fixes: #6276
Contribution Checklist