Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Fix MistralAI logging #6315

Merged
merged 1 commit into from
May 17, 2024

Conversation

stephentoub
Copy link
Member

  • The logger factory wasn't being forwarded to the chat completion service instance
  • The class wasn't logging tokens like the other connectors

Also made the others consistent in verbiage, metrics namespace, etc.

- The logger factory wasn't being forwarded to the chat completion service instance
- The class wasn't logging tokens like the other connectors

Also made the others consistent in verbiage, metrics namespace, etc.
@stephentoub stephentoub requested a review from a team as a code owner May 17, 2024 15:31
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels May 17, 2024
@github-actions github-actions bot changed the title Fix MistralAI logging .Net: Fix MistralAI logging May 17, 2024
@stephentoub stephentoub added this pull request to the merge queue May 17, 2024
Merged via the queue into microsoft:main with commit 0c89e0b May 17, 2024
17 checks passed
@stephentoub stephentoub deleted the fixmistrallogging branch May 17, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants