fix: add deadlines for all synchronous REST callers #19741
Merged
+56
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
add-deadlines
branch
from
8c67ef1
to
7834471
Compare
harshavardhana
commented
May 15, 2024
Comment on lines
+903
to
+914
| if totalResp >= minDisks && opts.FastGetObjInfo { | ||
| rw.Lock() | ||
| ok := countErrs(errs, errFileNotFound) >= minDisks || countErrs(errs, errFileVersionNotFound) >= minDisks | ||
| rw.Unlock() | ||
| if ok { | ||
| err = errFileNotFound | ||
| if opts.VersionID != "" { | ||
| err = errFileVersionNotFound | ||
| } | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
The idea is that the return file is not found faster; this is better for Head like calls.
vadmeste
reviewed
May 15, 2024
add deadlines that can be dynamically changed via the drive max timeout values. Bonus: optimize "file not found" case and hung drives /network - circuit break the check and return right away instead of waiting.
harshavardhana
force-pushed
the
add-deadlines
branch
from
7834471
to
5651be7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
fix: add deadlines for all synchronous REST callers
Motivation and Context
add deadlines that can be dynamically changed via
the drive max timeout values.
Bonus: optimize "file not found" case and hung drives/network -
circuit, break the check, and return right away instead of waiting.
How to test this PR?
It allows for the quick detection of hung nodes for all blocking operations.
Types of changes
Checklist:
commit-idorPR #here)