Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution options #702

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Contribution options #702

wants to merge 7 commits into from

Conversation

DanielAvdar
Copy link
Contributor

  1. Implemented a poetry option for contributors to diversify the pool of contributors.
  2. Revised the README file, incorporating a "Contribute" section with detailed instructions on installing requirements.
  3. Established a workflow to check contribution options through dispatch.

Please share your opinion and thoughts.

@pplonski
Copy link
Contributor

pplonski commented Feb 2, 2024

Thank you @DanielAvdar!

Is it possible to install packages from requirements.txt with poetry? I don't like to have many config files ...

@DanielAvdar
Copy link
Contributor Author

Hi @pplonski,

Unfortunately, it's not currently possible. I also prefer to avoid having too many configuration files. Here are the options:

  1. Omit Poetry changes and configuration files (poetry.toml, pyproject.toml). (Not recommended)
  2. Transition entirely to Poetry, eliminating setup.py and requirements files in favor of pyproject.toml and poetry.toml. (Recommended for later stages)
  3. Keep both options available, enduring the inconvenience of multiple configuration files for the short term. (Recommended)

Note: Initially, using setup.py with requirements files may seem simpler and more convient, as it has been the common way to handle Python projects for many years. However, with new standards requiring TOML files and the convenience of using Poetry, many contributors are discouraged by the old traditional way once they get accustomed to Poetry and TOML files. Therefore, transitioning to Poetry is often preferred in the long run.

@pplonski
Copy link
Contributor

pplonski commented Feb 2, 2024

Thank you @DanielAvdar, I need to think about it and read more about poetry.

@DanielAvdar DanielAvdar marked this pull request as draft February 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants