Default to "windows-dns-proxy":true #47826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 26.1, we added daemon feature flag "windows-dns-proxy" which could
be set to "true" to make "nslookup" work in Windows containers, by
forwarding requests from the internal resolver to the container's
external DNS servers.
This changes the default to forwarding-enabled - it can be disabled by
via daemon.json using ...
"features": { "windows-dns-proxy": false }
Signed-off-by: Rob Murray <rob.murray@docker.com>
robmry
added
platform/windows
status/2-code-review
kind/feature
akerouanton
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
In 26.1, #47584, we added daemon feature flag
windows-dns-proxywhich could be set totrueto makenslookupwork in Windows containers, by forwarding requests from the internal resolver to the container's external DNS servers.This changes the default to forwarding-enabled - it can be disabled by via daemon.json using ...
"features": { "windows-dns-proxy": false }(Follow-up ticket #47732 is about removing the feature flag if no problems are found with the new default.)
- How I did it
Changed the feature flag lookup.
- How to verify it
Manually tested an
nslookupfrom aservercore:ltsc2022container, with no flag in daemon.json, with it explicitly enabled and explicitly disabled.Updated integration test to expect the feature to be enabled by default.
- Description for the changelog