Add InitColorSchemeScript for Next.js App Router
#42247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
changed the title
InitColorSchemeScript for Next.js App RouterInitColorSchemeScript for Next.js App Router
siriwatknp
added
the
proof of concept
Netlify deploy preview
InitColorSchemeScript: parsed: +Infinity% , gzip: +Infinity% Bundle size reportDetails of bundle changes (Toolpad) |
github-actions
bot
added
the
PR: out-of-date
…nit-color-scheme-component
github-actions
bot
removed
the
PR: out-of-date
siriwatknp
changed the title
InitColorSchemeScript for Next.js App RouterInitColorSchemeScript for Next.js App Router
siriwatknp
added
package: material-ui
siriwatknp
commented
Jun 10, 2024
Comment on lines
+61
to
+62
| suppressHydrationWarning | ||
| nonce={typeof window === 'undefined' ? nonce : ''} |
There was a problem hiding this comment.
DiegoAndai
reviewed
Jun 10, 2024
| export { useColorScheme, getInitColorSchemeScript, CssVarsProvider, Experimental_CssVarsProvider }; | ||
| export { | ||
| useColorScheme, | ||
| getInitColorSchemeScript, |
There was a problem hiding this comment.
Should we deprecate getInitColorSchemeScript? Or do we expect users to still use it?
There was a problem hiding this comment.
Good point. I think it can be removed but I'd do it in a separate PR and add note to the migration doc in the same PR.
DiegoAndai
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #38913