Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for dark mode node icons and colors #9412

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented May 15, 2024

Summary

  • Add optional dark mode icons for nodes
  • Add node icon color presets for core nodes
// How to define a dark mode icon (backwards compatible)
icon: { light: 'file:googleSheets.svg', dark: 'file:googleSheetsDark.svg' }
icon: 'file:googleSheets.svg'

// How to define icon color from preset (has priority over `defaults.color`)
iconColor: 'blue'

Related tickets and issues

https://linear.app/n8n/issue/NODE-1337/dark-mode-icons-on-dark-mode

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels May 15, 2024
@elsmr elsmr marked this pull request as ready for review May 15, 2024 14:23
@elsmr elsmr changed the title feat: Add dark support for dark mode icons and colors feat: Add support for dark mode node icons and colors May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants