Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Address more type issues related to credentials and localization #9452

Closed
wants to merge 21 commits into from
Closed

refactor: Address more type issues related to credentials and localization #9452

wants to merge 21 commits into from

Conversation

mutdmour
Copy link
Contributor

Summary

Address more type issues related to credentials and localization

Related tickets and issues

TS cleanup

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 17, 2024
@mutdmour mutdmour requested a review from elsmr May 17, 2024 15:31
elsmr
elsmr previously approved these changes May 17, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented May 17, 2024 •
edited

5 failed tests on run #5059 ↗︎

5 227 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project: n8n Commit: be7c39ba3b
Status: Failed Duration: 04:21 💡
Started: May 21, 2024 10:08 AM Ended: May 21, 2024 10:12 AM
Failed  19-execution.cy.ts • 1 failed test

View Output Video

Test Artifacts
Execution > should send proper payload for node rerun Test Replay Screenshots Video
Failed  17-sharing.cy.ts • 4 failed tests

View Output Video

Test Artifacts
Sharing > should create C2, share C2 with U1 and U2, as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U2 Test Replay Screenshots Video
Sharing > should automatically test C2 when opened by U2 sharee Test Replay Screenshots Video
Failed  11-inline-expression-editor.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  9-expression-editor-modal.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  14-mapping.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 37 specs in Cypress Cloud.

Review all test suite changes for PR #9452 ↗︎

@mutdmour mutdmour requested a review from elsmr May 17, 2024 15:50
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@mutdmour mutdmour closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsmr elsmr elsmr approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mutdmour @elsmr