Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): Support JSON format in ConsoleLogger #13561

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nesro
Copy link

@nesro nesro commented May 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

ConsoleLoggerOptions interface has the new option asJSON with a JSDoc comment

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Currently, there is no way to make ConsoleLogger log JSON strings

Issue Number: N/A

What is the new behavior?

Now there is a option to log as JSON string

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

There is this issue #10342 that is closed, but still there is no support for JSON string format.

We are in a need of JSON string logs - it's easier to parse in Google Cloud and there are less problems with newlines.

Some projects that handle this issue exists:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 579eb5c0-6c1b-4f78-90af-24910b29a78e

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.124%

Totals Coverage Status
Change from base Build c5951846-b9c8-4626-baf3-314800754e97: 0.0%
Covered Lines: 6737
Relevant Lines: 7313

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants