Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Avoid updating the same oc_authtoken row twice #45349

Open
wants to merge 3 commits into
base: stable28
Choose a base branch
from
Open

[stable28] Avoid updating the same oc_authtoken row twice #45349

wants to merge 3 commits into from
+5 −1

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 16, 2024 •
edited by kesselb

@backportbot backportbot bot added this to the Nextcloud 28.0.6 milestone May 16, 2024
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 16, 2024
ChristophWurst
ChristophWurst requested changes May 16, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45026 (comment)

@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels May 21, 2024
@ChristophWurst ChristophWurst marked this pull request as draft May 21, 2024 06:17
@kesselb
Copy link
Contributor

kesselb commented May 29, 2024

Rebased the pull request on #45063 and cherry-picked #45411.

@kesselb kesselb marked this pull request as ready for review May 29, 2024 12:02
@kesselb
Copy link
Contributor

kesselb commented May 29, 2024

Merged #45063 and rebased again.

@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 29, 2024
juliushaertl and others added 3 commits May 31, 2024 17:30
@juliushaertl @kesselb
docs: Update token_auth_activity_update default value to match implem…
9b14de0 
…entation

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl @kesselb
fix: Always set last activity if we update the row of an authtoken an…
41528b1 
…yways

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@ChristophWurst @kesselb
fix(auth): Update authtoken activity selectively
9880800 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim approved these changes

@joshtrichards joshtrichards Awaiting requested review from joshtrichards

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Requested changes must be addressed to merge this pull request.

Assignees

@juliushaertl juliushaertl

Labels
3. to review Waiting for reviews enhancement feature: authentication performance 🚀
Projects
None yet
Milestone
Nextcloud 28.0.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kesselb @ChristophWurst @Altahrim @AndyScherzinger @juliushaertl