Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 12.4.254.17 #52980

Merged
merged 1 commit into from
May 18, 2024
Merged

deps: patch V8 to 12.4.254.17 #52980

merged 1 commit into from
May 18, 2024

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated patch update of V8 to 12.4.254.17.

@nodejs-github-bot nodejs-github-bot added v8 engine Issues and PRs related to the V8 dependency. needs-ci PRs that need a full CI run. labels May 14, 2024
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2024
@targos targos mentioned this pull request May 14, 2024
Merged
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2024
@targos targos mentioned this pull request May 14, 2024
Closed
@mbhatt1 mbhatt1 mentioned this pull request May 14, 2024
Closed
@targos
Copy link
Member

targos commented May 15, 2024

So, when we re-run the action, does like a rebase. I like that.

@targos
Copy link
Member

targos commented May 15, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59222/

@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented May 17, 2024 •
edited by richardlau

CI: https://ci.nodejs.org/job/node-test-pull-request/59270/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/5986/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7380252 into main May 18, 2024
43 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/update-v8-patch branch May 18, 2024 13:42
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 7380252

targos pushed a commit that referenced this pull request May 21, 2024
@nodejs-github-bot @targos
deps: patch V8 to 12.4.254.17
6d8589e 
Refs: v8/v8@12.4.254.14...12.4.254.17
PR-URL: #52980
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nodejs-github-bot @targos @lpinca @anonrig @marco-ippolito @VoltrexKeyva