Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add links to security steward companies #52981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RedYetiDev
Copy link
Member

This PR adds links to the security steward companies, in case anyone wants to visit them.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 14, 2024
@benjamingr benjamingr added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 14, 2024
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there are foundation or project implications to this so I'd like @nodejs/tsc to weigh in on this before we land.

(I don't personally object, this just seems like the kind of thing the TSC would need to OK)

@tniessen
Copy link
Member

in case anyone wants to visit them.

This seems like yet another PR that assumes user's intentions without providing any evidence that our users actually want this.

Is the front page of the IBM website really going to provide helpful information to Node.js users or contributors? How so? That company alone employs nearly 300,000 people and I assume that 99.9 % of them have nothing to do with Node.js.

@RedYetiDev
Copy link
Member Author

This seems like yet another PR that assumes user's intentions without providing any evidence that our users actually want this.

Is the front page of the IBM website really going to provide helpful information to Node.js users or contributors? How so? That company alone employs nearly 300,000 people and I assume that 99.9 % of them have nothing to do with Node.js.

I dont think I'm assuming the user intention, but giving them an opportunity to explore, they don't have to explore these sites, but if they (for some reason) want to, they have the ability to.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@H4ad H4ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RedYetiDev RedYetiDev removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 25, 2024
@RedYetiDev
Copy link
Member Author

Removing TSC agenda, as the meeting took place, and there were no concerns

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@benjamingr just a ping to check if you think this should still be blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet