tls: fix negative sessionTimeout handling #53002
Merged
+33
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historical reasons, the second argument of
SSL_CTX_set_timeout
is a signed integer, and Node.js has so far passed arbitrary (signed)int32_t
values. However, new versions of OpenSSL have changed the handling of negative values insideSSL_CTX_set_timeout
, and we should shield users of Node.js from both the old and the new behavior. Hence, reject any negative values by throwing an error from withincreateSecureContext
.Refs: openssl/openssl#19082