Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertiesComparer: Show actual property and value that fails equality #4712

Merged
merged 2 commits into from
May 20, 2024
Merged

PropertiesComparer: Show actual property and value that fails equality #4712

merged 2 commits into from
May 20, 2024

Conversation

manfred-brands
Copy link
Member

Fixes #4710

@manfred-brands manfred-brands force-pushed the issue4710_ImprovePropertiesComparerMessage branch from da135ab to 69a8685 Compare May 15, 2024 14:44
OsirisTerje
OsirisTerje approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few small nitpicks.

And, consider the nulls.

src/NUnitFramework/framework/Constraints/NUnitEqualityComparer.cs Show resolved Hide resolved
src/NUnitFramework/framework/Constraints/EqualConstraintResult.cs Outdated Show resolved Hide resolved
src/NUnitFramework/framework/Constraints/Comparers/PropertiesComparer.cs Outdated Show resolved Hide resolved
@OsirisTerje
Copy link
Member

@manfred-brands merge ?

@manfred-brands manfred-brands merged commit f412649 into master May 20, 2024
5 checks passed
@manfred-brands manfred-brands deleted the issue4710_ImprovePropertiesComparerMessage branch May 20, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OsirisTerje OsirisTerje OsirisTerje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve PropertiesComparer diagnostics
2 participants
@manfred-brands @OsirisTerje