Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Coverlet Coverage to builds #4286

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

SeanKilleen
Copy link
Member

@SeanKilleen SeanKilleen commented Feb 3, 2023

Resolves #423.

Putting this out here in super-draft form just to get it started.

  • Updates Cake to v3 and adjusts cake file to new conventions since v1
  • Introduces Cake.Coverlet as an add-in
  • Adds Coverlet collector as part of the tool manifest
  • Updates the testing task to use Cake command & coverlet settings

@SeanKilleen
Copy link
Member Author

(I only just now realized that GitHub runs the CI for draft pull requests too -- very helpful to get the benefits of CI without bugging anyone with notifications.)

@manfred-brands
Copy link
Member

GitHub is still notifying, even for draft PRs.

@stevenaw
Copy link
Member

@SeanKilleen I don't know if I'd have the time to help with this myself, but would you be open to if someone were to help get this back in sync with recent changes and eventually help get this merged?

@SeanKilleen
Copy link
Member Author

@stevenaw I'll see if I can take a look at this tonight. Thanks for the ping! I've been all over the place with job stuff and kid being sick for a few weeks, Good to have the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Code Coverage into CI
3 participants