Change range semantic to behaves more like rust. #12890
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have decided to make range to behave like rust, that is:
This pr also:
1..<3
syntax. The main change is happened incrates/nu-parser/src/parser.rs:parse_range
crates/nu-cmd-base/src/util.rs
detect_columns
(for-c
flag)str substring
str index-of
(for-r
flag)bytes at
Take
str substring
as example:Before
After
The result of
"abcd" | str substring 1..3
remains unchanged because the semantic of1..3
is changed from[1,2,3]
to[1,2]
, so it returns "bc".Apart from changes in
crates/nu-parser/src/parser.rs:parse_range
andcrates/nu-cmd-base/src/util.rs
, remaining changes are most about adjusting test code to follow new semanticFixes: #7761
User-Facing Changes
It's a big breaking change, because the semantic of
1..3
is changed from[1,2,3]
to[1,2]
Tests + Formatting
Adjusted all tests
After Submitting
Need to update documentation about ranges