feat(nuxt): namespace global variables for multi-app support #27263
+74
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nicolaspayot
changed the title
nicolaspayot
force-pushed
the
feat/nuxt/multi-app-global-vars
branch
from
f30a78c
to
b2ff8da
Compare
manniL
reviewed
May 19, 2024
| @@ -50,6 +50,7 @@ export default defineNuxtPlugin({ | |||
| } | |||
| Object.assign(nuxtApp.payload, await nuxtApp.runWithContext(getNuxtClientPayload)) | |||
| // For backwards compatibility - TODO: remove later | |||
There was a problem hiding this comment.
I'm still wondering if we have to set the payload here / why it was marked for compat only?
nicolaspayot
force-pushed
the
feat/nuxt/multi-app-global-vars
branch
from
b2ff8da
to
2c3f046
Compare
| @@ -409,6 +409,7 @@ export const nuxtConfigTemplate: NuxtTemplate = { | |||
| `export const vueAppRootContainer = ${ctx.nuxt.options.app.rootId ? `'#${ctx.nuxt.options.app.rootId}'` : `'body > ${ctx.nuxt.options.app.rootTag}'`}`, | |||
| `export const viewTransition = ${ctx.nuxt.options.experimental.viewTransition}`, | |||
| `export const appId = ${JSON.stringify(ctx.nuxt.options.appId)}`, | |||
| `export const multiApp = ${!!ctx.nuxt.options.future.multiApp}`, | |||
There was a problem hiding this comment.
I think that there are better and more explicit for this variable, eg: runningMultipleApp, usingMultipleApp.
Imo the current name is easy to be misleading to end users, and maybe also module developers.
There was a problem hiding this comment.
Sure. runningMultiApp sounds good to me. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
2nd task of #21635. Also linked to #25336 although it doesn't completely remove
window.__NUXT__.📚 Description
This PR updates
window.__NUXT__global variable to handle multi-app payloads and config by storing the data under theirappId.Before:
After:
It also replaces scripts global IDs
__NUXT_DATA__and__NUXT_LOGS__with data attributes:Before:
After:
This will eventually allows the use of multiple Nuxt applications on a same page.
📝 To do:
future/experimentalflagwindow.__NUXT__update innuxt/test-utils. See feat: add multi-app support for global var__NUXT__test-utils#858