Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External ticket support of ticketing systems like salesforce. #1067

Merged
merged 12 commits into from
May 17, 2024

Conversation

PavelJurka
Copy link
Contributor

@PavelJurka PavelJurka commented Apr 30, 2024

description

Add a way, to link external ticket to the incident OCSF.

Related Issue:

#1068

Description of changes:

defined external ticket object and used in incident finding - url, uid and title

…n url + uid, title optional, linked from incident finding.
…n url + uid, title optional, linked from incident finding.
@PavelJurka PavelJurka marked this pull request as ready for review May 2, 2024 09:13
@mikeradka mikeradka added enhancement New feature or request findings Issues related to Findings Category v1.3.0 and later Changes marked for versions beyond v1.3.0 of OCSF labels May 3, 2024
@mikeradka
Copy link
Contributor

mikeradka commented May 3, 2024

Here are two recommendations for consideration:

  1. Exercise caution when designating attributes as required. For uid and src_url, it may be prudent to classify them as recommended and enforce a constraint ensuring that at least one is provided within the object.
  2. To enhance flexibility and minimize implementation specificity, it is advisable to replace external_ticket with a more generic term such as ticket. Additionally, introducing an enumeration to distinguish between internal and external tickets could further refine this attribute.

@PavelJurka
Copy link
Contributor Author

Here are two recommendations for consideration:

  1. Exercise caution when designating attributes as required. For uid and src_url, it may be prudent to classify them as recommended and enforce a constraint ensuring that at least one is provided within the object.
  2. To enhance flexibility and minimize implementation specificity, it is advisable to replace external_ticket with a more generic term such as ticket. Additionally, introducing an enumeration to distinguish between internal and external tickets could further refine this attribute.

thank you!

dictionary.json Outdated Show resolved Hide resolved
@PavelJurka PavelJurka requested a review from floydtree May 8, 2024 12:01
CHANGELOG.md Outdated Show resolved Hide resolved
@PavelJurka PavelJurka requested a review from mikeradka May 9, 2024 07:31
Signed-off-by: Pavel Jurka <pavel.jurka@sentinelone.com>
mikeradka
mikeradka previously approved these changes May 16, 2024
Signed-off-by: Pavel Jurka <pavel.jurka@sentinelone.com>
@PavelJurka PavelJurka requested a review from mikeradka May 17, 2024 12:38
@floydtree floydtree merged commit 3e8dc0f into ocsf:main May 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request findings Issues related to Findings Category v1.3.0 and later Changes marked for versions beyond v1.3.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants