Feat: [#1069] - added signature state id into the Digital signature #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to map the current signature state.
PavelJurka
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka and
zschmerber
as code owners
PavelJurka
changed the title
PavelJurka
changed the title
|
We discussed this a bit offline, and it looks like to avoid adding a new dictionary object, we could accomplish this by simply using the |
mikeradka
added
enhancement
floydtree
requested changes
May 3, 2024
Thank you, that make sense. |
Signed-off-by: Pavel Jurka <pavel.jurka@sentinelone.com>
Aniak5
reviewed
May 9, 2024
floydtree
approved these changes
May 15, 2024
pagbabian-splunk
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
Map the signature state to signature state id (+signature state as usual)
Related Issue:
#1069
Description of changes:
signature_state_id: optional
0 Unknown
1 Valid
2 Expired
3 Revoked
9 Other
signature_state: optional String as a value of signature_state_id, custom in a case of 99 as usual.