Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create storage bucket.json #1085

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vabmalikusa
Copy link

Related Issue:

Description of changes:

Delete once you have confirmed the following:

  1. Did you add a single line summary of changes to Unreleased section in the CHANGELOG.md file?
  2. Have you followed the contribution guidelines?
  3. Did you run a local instance of the ocsf-server and ensure it ran without any errors/warnings?
  4. Is your PR title in sync with the description?

Signed-off-by: Vaibhav Malik <vabmalikusa@gmail.com>
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to your other 2 PRs,

Thank you for the interest in contributing to OCSF.

About the content itself, it would be good understand the use-case of the new object that you are proposing and where you would like to use those in the framework. First creating a github issue to go over gap and the proposed solution would help us review it better.

Also, the json file itself seems to have been incorrectly defined. Following the contribution guidelines, running a local ocsf-server should help you identify & rectify the issues in the json file.

Finally, please fill out the PR descriptions accurately and follow the guidelines mentioned within.

@pagbabian-splunk
Copy link
Contributor

Also take a look at the Datastore Activity class in the Application category. There is a databucket object as part of that class. https://schema.ocsf.io/1.3.0-dev/objects/databucket?extensions=

@davemcatcisco
Copy link
Contributor

davemcatcisco commented May 27, 2024

It's clear from the attributes in the storage_bucket object that the type of storage bucket being referred to is an S3 bucket or similar, i.e. the cloud-specific meaning of the term. However, the term storage bucket has a more general meaning in software engineering that probably predates the cloud-specific meaning by a couple of decades. Because the OCSF schema covers a very broad range of applications and operating contexts, I feel that OCSF event classes and objects shouldn't use a general term in a way that precludes other meanings and interpretations.

My request therefore is that you change:

  • storage_bucket to cloud_storage_bucket
  • Storage Bucket to Cloud Storage Bucket
  • etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants