[FW][FIX] l10n_hu_edi: Various fixes #166076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antoine162 @jco-odoo this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@antoine162 @jco-odoo ci/runbot failed on this forward-port PR |
1. Avoid crashing if move.name is not set
In the tests
`:TestAccountMoveInInvoiceOnchanges.test_fiduciary_mode_date_suggestion`
`:TestSequenceMixin.test_sequence_empty_editable_with_quick_edit_mode`
the compute method `_compute_l10n_hu_edi_attachment_filename` gets
called before the invoice name is set.
Because of this, calling move.name.replace('/', '_') was raising an
AttributeError.
2. Allow user to not put credentials in demo mode.
3. sent (waiting for response) and confirmed_warning states don't raise
a UserError and don't block an e-mail from being sent to the customer
anymore.
4. always send modification invoices using 'MODIFY' (never 'STORNO')
since in Odoo we can't predict whether the user will want to issue
further corrections to an invoice in the future.
5. Remove 'countries': ['hu'] in __manifest__.py to align with
odoo/enterprise#56251
Fixes runbot errors 64755 and 64756.
X-original-commit: f8fd100
antoine162
force-pushed
the
master-17.0-l10n_hu_edi-fix-nightly-tests-andu-01MA-fw
branch
from
94ded0a
to
7b9921b
Compare
|
@antoine162 @jco-odoo this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo) |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
1. Avoid crashing if move.name is not set
In the tests
`:TestAccountMoveInInvoiceOnchanges.test_fiduciary_mode_date_suggestion`
`:TestSequenceMixin.test_sequence_empty_editable_with_quick_edit_mode`
the compute method `_compute_l10n_hu_edi_attachment_filename` gets
called before the invoice name is set.
Because of this, calling move.name.replace('/', '_') was raising an
AttributeError.
2. Allow user to not put credentials in demo mode.
3. sent (waiting for response) and confirmed_warning states don't raise
a UserError and don't block an e-mail from being sent to the customer
anymore.
4. always send modification invoices using 'MODIFY' (never 'STORNO')
since in Odoo we can't predict whether the user will want to issue
further corrections to an invoice in the future.
5. Remove 'countries': ['hu'] in __manifest__.py to align with
odoo/enterprise#56251
Fixes runbot errors 64755 and 64756.
closes #166076
X-original-commit: f8fd100
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Antoine Dupuis (andu) <andu@odoo.com>
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 24, 2024
1. Avoid crashing if move.name is not set
In the tests
`:TestAccountMoveInInvoiceOnchanges.test_fiduciary_mode_date_suggestion`
`:TestSequenceMixin.test_sequence_empty_editable_with_quick_edit_mode`
the compute method `_compute_l10n_hu_edi_attachment_filename` gets
called before the invoice name is set.
Because of this, calling move.name.replace('/', '_') was raising an
AttributeError.
2. Allow user to not put credentials in demo mode.
3. sent (waiting for response) and confirmed_warning states don't raise
a UserError and don't block an e-mail from being sent to the customer
anymore.
4. always send modification invoices using 'MODIFY' (never 'STORNO')
since in Odoo we can't predict whether the user will want to issue
further corrections to an invoice in the future.
5. Remove 'countries': ['hu'] in __manifest__.py to align with
odoo/enterprise#56251
Fixes runbot errors 64755 and 64756.
closes odoo#166076
X-original-commit: f8fd100
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Antoine Dupuis (andu) <andu@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tests
:TestAccountMoveInInvoiceOnchanges.test_fiduciary_mode_date_suggestion:TestSequenceMixin.test_sequence_empty_editable_with_quick_edit_modethe compute method
_compute_l10n_hu_edi_attachment_filenamewas called before the invoice name was set.Because of this, calling move.name.replace('/', '_') was raising an AttributeError.
Allow user to not put credentials when they are using demo mode.
sent (waiting for response) and confirmed_warning states should not raise a UserError and should not block an e-mail from being sent to the customer.
always send modification invoices using 'MODIFY' (never 'STORNO') since 'STORNO' prevents further modifications from being issued to the invoice, but in Odoo we can't predict whether the user will want to issue further corrections to an invoice in the future.
Fixes runbot errors 64755 and 64756.
Forward-Port-Of: #165897
Forward-Port-Of: #165195