[FW][FIX] mail: show all attachment options #166086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@reth-odoo ci/runbot failed on this forward-port PR |
|
@fw-bot retry |
reth-odoo
force-pushed
the
saas-17.1-17.0-show-all-attachment-options-when-deletable-reth-Pl2I-fw
branch
from
b1b088d
to
d8f3a60
Compare
|
@robodoo r+ rebased |
|
@reth-odoo this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo) |
The template for the attachment list adds a class to show multiple options when attachments can be deleted. However the condition to display the delete button is different from the condition to apply that style. Meaning if one condition `showDelete` is true while the other `isDeletable` is false it is impossible to access the download button as the correct style is not applied. - Fix the template to use the same condition everywhere - Fix the condition for showDelete to always be false is deletion is disallowed Issue noticeable since [1] when attachments were made conditionally deletable as opposed to always deletable previously. 1: 32a80a3 task-3519815 X-original-commit: 56b3f67
reth-odoo
force-pushed
the
saas-17.1-17.0-show-all-attachment-options-when-deletable-reth-Pl2I-fw
branch
from
d8f3a60
to
3ce0d76
Compare
|
Switch to patchUserWithCleanup, user service not available and this is more reliable. |
robodoo
pushed a commit
that referenced
this pull request
May 19, 2024
The template for the attachment list adds a class to show multiple options when attachments can be deleted. However the condition to display the delete button is different from the condition to apply that style. Meaning if one condition `showDelete` is true while the other `isDeletable` is false it is impossible to access the download button as the correct style is not applied. - Fix the template to use the same condition everywhere - Fix the condition for showDelete to always be false is deletion is disallowed Issue noticeable since [1] when attachments were made conditionally deletable as opposed to always deletable previously. 1: 32a80a3 task-3519815 closes #166086 X-original-commit: 56b3f67 Signed-off-by: Renaud Thiry (reth) <reth@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template for the attachment list adds a class to show multiple options when attachments can be deleted.
However the condition to display the delete button is different from the condition to apply that style.
Meaning if one condition
showDeleteis true while the otherisDeletableis false it is impossible to access the download button as the correct style is not applied.Issue noticeable since [1] when attachments were made conditionally deletable as opposed to always deletable previously.
Steps to reproduce:
1: 32a80a3
task-3519815
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #165332