This repository has been archived by the owner on Sep 6, 2019. It is now read-only.
Improved state/preset persistence in VST3 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix plugin crash when cancelling DumpPreset functions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some modifications that improve state/preset persistence in VST3 builds (only tested on Windows). These seem to work consistently/well with plugins using chunks but not as well when using MakePreset() or MakePresetFromNamedParams()
.vstpreset files can be imported/exported using Reaper's plugin preset utility menu, whereas they were greyed-out before.
.vstpreset files created in Sonar are compatible with ones created in Reaper and vice versa. I'm not sure about FLStudio as I only have a demo that is restricted in its ability to save..... .vstpreset files load well though. Other than SaviHost, those are the only hosts I've tested.
When kNumPrograms is greater than 1, the bank state is saved/recalled in both host project and .vstpreset files.
fixed an issue where the plugin would crash when cancelling a "DumpPresets" operation.
Modified IPlugChunks example project to demonstrate the improvements.