[fix] fix the build command for symbiyosys #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `run` step of the symbiyosys backend generates a `sby` command which includes the hardcoded `-d build` argument. However, this command line argument is incompatible with multiple tasks.
This fix removes the hardcoded `-d` argument and introduces a new `extra_options` tool option for the symbiyosys backend, which can be used to pass additional arguments for the `sby` command (e.g. `-d build`, if necessary).
The example usage of the `extra_options`:
```
symbiyosys:
tasknames:
# A list of task names to pass to sby. Defaults to empty (in which case
# sby will run each task in the .sby file)
- my_proof
extra_options:
# A list of extra command line arguments to sby. Defaults to empty.
- -d
- build
```
Henkru
commented
Dec 29, 2022
| @@ -108,8 +112,10 @@ class Symbiyosys(Edatool): | |||
| "lists": { | |||
| # A list of tasks to run from the .sby file. Passed on the sby | |||
| # command line. | |||
| "tasknames": "String" | |||
| } | |||
| "tasknames": "String", | |||
There was a problem hiding this comment.
Is this tool_options some legacy stuff? Other edatool classes are using TOOL_OPTIONS with a different structure.
There was a problem hiding this comment.
This backend is part of the legacy tool API. The classes under the tools and flows directories belong to the new flow API. Unfortunately most tools haven't been ported over to the new API yet.
|
Thanks. This sounds good to me. Hard coded parameters should be avoided as far as possible. I would like to rename |
ollie-etl
added a commit
to etlsystems/edalize
that referenced
this pull request
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
runstep of the symbiyosys backend generates asbycommand which includes the hardcoded-d buildargument. However, this command line argument is incompatible with multiple tasks (see #257).If the
-d buildargument is specified, the output folder of sby is forced tobuild/<core>/<target>-symbiyosys/build. Otherwise, the following path is used:build/<core>/<target>-symbiyosys/test_<taskname>.This fix removes the hardcoded
-dargument and introduces a newextra_optionstool option for the symbiyosys backend, which can be used to pass additional arguments for thesbycommand (e.g.-d build, if necessary).The example usage of the
extra_options:Closes #257.