Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript: add node v20 to default known versions #20617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinobruno
Copy link
Contributor

Add nodejs v20 to default known versions as its the current LTS https://endoflife.date/nodejs.

I naively tried to bump the default_version to v20.11.1, but a lot of tests fails for reasons I'm still not sure.

Adding the v20 to default_known_versions at least reduces the pants.toml file when anyone wants to use the v20 as only the version option of the nodejs subsystem will need to be specified.

I plan to explore more about the upgrade from node v16 to v20 and putting a PR to change the default_version to v20 soon.

Related to #19131

@kaos
Copy link
Member

kaos commented Feb 26, 2024

Thanks for looking into this!

I think we want to upgrade default_known_versions at the same time as default_version. If tests starts failing, it doesn't feel like we want to say we support v20 yet.. so adding that version to default_known_versions kind of gives the wrong impression then.

@huonw
Copy link
Contributor

huonw commented Apr 16, 2024

Heya @tobni, the test failures here looks like something you might have insight into. What do you think?

@huonw huonw requested a review from tobni April 16, 2024 23:08
Copy link
Contributor

@tobni tobni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corepack and nodejs are distributed together. The failures are almost certainly tied to the bundled version of corepack being a later version, and either that in and of itself being a source of failure (corepack is not version 1 yet), or the newer version of corepack bumping default versions of package managers which in turn tend to not follow semver particularily well w.r.t CLI-surface. https://nodejs.org/docs/latest-v20.x/api/corepack.html

I would advice incrementing to v18 first just to see and review errors from there first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants