fix ibc hooks to not throw error on every ack. (#388)

* fix ibc hooks to not throw error on every ack. * fix lint
persistenceOne · Mar 17, 2023 · 7678b4f · 7678b4f
1 parent 29d8858
commit 7678b4f
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/x/ibchooker/types/hooks.go b/x/ibchooker/types/hooks.go
@@ -23,8 +23,11 @@ func (h MultiIBCHandshakeHooks) OnRecvPacket(ctx sdk.Context, packet types.Packe
 			//nolint:scopelint
 			return h[i].OnRecvPacket(ctx, packet, relayer, transferAck)
 		}
+
 		err := utils.ApplyFuncIfNoError(ctx, wrappedHookFn)
-		ctx.Logger().Error("Error occurred in calling OnRecvPacket hooks, ", "err: ", err, "module:", ModuleName, "index:", i)
+		if err != nil {
+			ctx.Logger().Error("Error occurred in calling OnRecvPacket hooks, ", "err: ", err, "module:", ModuleName, "index:", i)
+		}
 	}
 
 	return nil
@@ -36,8 +39,11 @@ func (h MultiIBCHandshakeHooks) OnAcknowledgementPacket(ctx sdk.Context, packet
 			//nolint:scopelint
 			return h[i].OnAcknowledgementPacket(ctx, packet, acknowledgement, relayer, transferAckErr)
 		}
+
 		err := utils.ApplyFuncIfNoError(ctx, wrappedHookFn)
-		ctx.Logger().Error("Error occurred in calling OnAcknowledgementPacket hooks, ", "err: ", err, "module:", ModuleName, "index:", i)
+		if err != nil {
+			ctx.Logger().Error("Error occurred in calling OnAcknowledgementPacket hooks, ", "err: ", err, "module:", ModuleName, "index:", i)
+		}
 	}
 
 	return nil
@@ -49,8 +55,11 @@ func (h MultiIBCHandshakeHooks) OnTimeoutPacket(ctx sdk.Context, packet types.Pa
 			//nolint:scopelint
 			return h[i].OnTimeoutPacket(ctx, packet, relayer, transferTimeoutErr)
 		}
+
 		err := utils.ApplyFuncIfNoError(ctx, wrappedHookFn)
-		ctx.Logger().Error("Error occurred in calling OnTimeoutPacket hooks, ", "err: ", err, "module:", ModuleName, "index:", i)
+		if err != nil {
+			ctx.Logger().Error("Error occurred in calling OnTimeoutPacket hooks, ", "err: ", err, "module:", ModuleName, "index:", i)
+		}
 	}
 
 	return nil