Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cosmos-sdk to v47 #400

Merged
merged 27 commits into from
Jun 20, 2023
Merged

chore: bump cosmos-sdk to v47 #400

merged 27 commits into from
Jun 20, 2023

Conversation

ajeet97
Copy link
Contributor

@ajeet97 ajeet97 commented May 12, 2023

1. Overview

  • bumps cosmos-sdk to v0.47.2 (using persistence's fork with LSM), which required these deps updates
    • migrate to comebft
    • ibc-go to v7.0.0 (persistence's fork)
  • refactored simapp code according to the sdk47 simapp.
  • using ghcr.io/cosmos/proto-builder to generate protobuf files
  • removed x/lsnative (LSM) module as it is moved to forked version of cosmos-sdk
  • removed ibctesting pkg (not needed as LSM is moved out)

@ajeet97 ajeet97 requested a review from xlab May 12, 2023 15:14
Copy link
Contributor

@xlab xlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far is good.

Need to figure out how to combine buf with forked proto files from a forked cosmos-sdk (in favour of lsm).

Also, I think ibctesting should be gone if we manage to update LSM through forked cosmos sdk.

@ajeet97 ajeet97 marked this pull request as ready for review May 22, 2023 14:49
@github-actions
Copy link

Coverage after merging ajeet/sdk-v47 into master

18.75%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   genesis.go100%100%0%19, 20, 21
   test_suite.go100%100%0%..., 52, 53, 54, 56
   encoding.go100%100%100%
   genesis_account.go100%100%100%
   test_helpers.go100%100%18.01%..., 53, 54, 55, 56
   export.go100%100%13.43%..., 96, 97, 98, 99
   app.go100%100%84.93%..., 855, 858, 859, 860
simapp/simd/cmd
   root.go100%100%80.37%..., 68, 69, 72, 73
   testnet.go100%100%69.54%..., 533, 534, 91, 92
   genaccounts.go100%100%71.54%..., 95, 96, 97, 98
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
x/epochs/keeper
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
   abci.go100%100%100%
   hooks.go100%100%100%
   genesis.go100%100%90.91%14
   epoch.go100%100%85.71%..., 25, 61, 87, 92
   keeper.go100%100%92.86%30
x/epochs/types
   hooks.go100%100%100%
   genesis.go100%100%59.18%..., 57, 58, 61, 62
   genesis.pb.go100%100%28.80%..., 96, 97, 98, 99
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
x/halving/simulation
   genesis.go100%100%70%17, 18, 19
x/halving/types
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   genesis.go100%100%86.67%25, 26
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   params.go100%100%85.29%24, 25, 26, 44, 45
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
x/interchainquery
   handler.go100%100%0%15, 16, 17, 18, 19
   genesis.go100%100%54.55%21, 22, 23, 24, 25
   module.go100%100%63.38%..., 84, 87, 88, 89
x/interchainquery/keeper
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
   keeper.go100%100%67.59%..., 43, 66, 67, 89
   msg_server.go100%100%55.74%..., 76, 79, 87, 88
   abci.go100%100%92.68%58, 59, 60
   queries.go100%100%98%67
x/interchainquery/types
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999
   codec.go100%100%100%
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
   msgs.go100%100%54.17%..., 39, 45, 46, 47
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   keys.go100%100%0%22, 23, 24
   genesis.go100%100%63.64%15, 16, 17, 18
x/oracle/keeper
   reward.go100%100%91.67%14, 15, 72, 88
   alias_functions.go100%100%100%
   genesis.go100%100%93.33%..., 34, 43, 52, 63
   msg_server.go100%100%75.83%..., 81, 82, 85, 86
   keeper.go100%100%93.45%..., 47, 68, 69, 70
   grpc_query.go100%100%15.29%..., 96, 97, 98, 99
   utils.go100%100%77.78%10, 9
   ballot.go100%100%100%
   tally.go100%100%93.55%..., 113, 114, 60, 61
   slash.go100%100%97.44%41
   params.go100%100%68.89%..., 75, 79, 80, 81
x/oracle/types
   genesis.go100%100%66.67%..., 23, 24, 25, 26
   query.pb.go100%100%0.83%..., 969, 97, 98, 99
   query.pb.gw.go100%100%0%..., 95, 97, 98, 99
   denom.go100%100%100%
   genesis.pb.go100%100%0.93%..., 993, 994, 998, 999
   keys.go100%100%0%..., 52, 53, 54, 55
   tx.pb.go100%100%0.90%..., 993, 994, 996, 999
   hash.go100%100%68.42%..., 65, 66, 68, 69
   params.go100%100%88.59%..., 296, 297, 298, 300
   codec.go100%100%52.38%..., 45, 46, 47, 48
   oracle.pb.go100%100%0.76%..., 995, 996, 997, 998
   ballot.go100%100%96.61%110, 111, 195, 196
   vote.go100%100%100%
   msgs.go100%100%76.19%..., 37, 54, 55, 90

@github-actions
Copy link

Coverage after merging ajeet/sdk-v47 into master

18.75%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   export.go100%100%13.43%..., 96, 97, 98, 99
   genesis_account.go100%100%100%
   genesis.go100%100%0%19, 20, 21
   encoding.go100%100%100%
   test_suite.go100%100%0%..., 52, 53, 54, 56
   app.go100%100%84.93%..., 855, 858, 859, 860
   test_helpers.go100%100%18.01%..., 53, 54, 55, 56
simapp/simd/cmd
   root.go100%100%80.37%..., 68, 69, 72, 73
   testnet.go100%100%69.54%..., 533, 534, 91, 92
   genaccounts.go100%100%71.54%..., 95, 96, 97, 98
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
x/epochs/keeper
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
   abci.go100%100%100%
   genesis.go100%100%90.91%14
   hooks.go100%100%100%
   epoch.go100%100%85.71%..., 25, 61, 87, 92
   keeper.go100%100%92.86%30
x/epochs/types
   genesis.go100%100%59.18%..., 57, 58, 61, 62
   genesis.pb.go100%100%28.80%..., 96, 97, 98, 99
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   hooks.go100%100%100%
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
x/halving/simulation
   genesis.go100%100%70%17, 18, 19
x/halving/types
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   params.go100%100%85.29%24, 25, 26, 44, 45
   genesis.go100%100%86.67%25, 26
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
x/interchainquery
   handler.go100%100%0%15, 16, 17, 18, 19
   module.go100%100%63.38%..., 84, 87, 88, 89
   genesis.go100%100%54.55%21, 22, 23, 24, 25
x/interchainquery/keeper
   abci.go100%100%92.68%58, 59, 60
   queries.go100%100%98%67
   msg_server.go100%100%55.74%..., 76, 79, 87, 88
   keeper.go100%100%67.59%..., 43, 66, 67, 89
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
x/interchainquery/types
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
   msgs.go100%100%54.17%..., 39, 45, 46, 47
   codec.go100%100%100%
   genesis.go100%100%63.64%15, 16, 17, 18
   keys.go100%100%0%22, 23, 24
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999
x/oracle/keeper
   genesis.go100%100%93.33%..., 34, 43, 52, 63
   alias_functions.go100%100%100%
   keeper.go100%100%93.45%..., 47, 68, 69, 70
   reward.go100%100%91.67%14, 15, 72, 88
   utils.go100%100%77.78%10, 9
   params.go100%100%68.89%..., 75, 79, 80, 81
   tally.go100%100%93.55%..., 113, 114, 60, 61
   slash.go100%100%97.44%41
   ballot.go100%100%100%
   grpc_query.go100%100%15.29%..., 96, 97, 98, 99
   msg_server.go100%100%75.83%..., 81, 82, 85, 86
x/oracle/types
   tx.pb.go100%100%0.90%..., 993, 994, 996, 999
   params.go100%100%88.59%..., 296, 297, 298, 300
   oracle.pb.go100%100%0.76%..., 995, 996, 997, 998
   codec.go100%100%52.38%..., 45, 46, 47, 48
   genesis.pb.go100%100%0.93%..., 993, 994, 998, 999
   denom.go100%100%100%
   vote.go100%100%100%
   msgs.go100%100%76.19%..., 37, 54, 55, 90
   keys.go100%100%0%..., 52, 53, 54, 55
   hash.go100%100%68.42%..., 65, 66, 68, 69
   query.pb.gw.go100%100%0%..., 95, 97, 98, 99
   genesis.go100%100%66.67%..., 23, 24, 25, 26
   ballot.go100%100%96.61%110, 111, 195, 196
   query.pb.go100%100%0.83%..., 969, 97, 98, 99

@github-actions
Copy link

Coverage after merging ajeet/sdk-v47 into master

18.75%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   genesis.go100%100%0%19, 20, 21
   test_suite.go100%100%0%..., 52, 53, 54, 56
   encoding.go100%100%100%
   app.go100%100%84.93%..., 855, 858, 859, 860
   export.go100%100%13.43%..., 96, 97, 98, 99
   genesis_account.go100%100%100%
   test_helpers.go100%100%18.01%..., 53, 54, 55, 56
simapp/simd/cmd
   genaccounts.go100%100%71.54%..., 95, 96, 97, 98
   testnet.go100%100%69.54%..., 533, 534, 91, 92
   root.go100%100%80.37%..., 68, 69, 72, 73
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
x/epochs/keeper
   abci.go100%100%100%
   epoch.go100%100%85.71%..., 25, 61, 87, 92
   genesis.go100%100%90.91%14
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
   keeper.go100%100%92.86%30
   hooks.go100%100%100%
x/epochs/types
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
   genesis.go100%100%59.18%..., 57, 58, 61, 62
   hooks.go100%100%100%
   genesis.pb.go100%100%28.80%..., 96, 97, 98, 99
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
x/halving/simulation
   genesis.go100%100%70%17, 18, 19
x/halving/types
   genesis.go100%100%86.67%25, 26
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
   params.go100%100%85.29%24, 25, 26, 44, 45
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
x/interchainquery
   handler.go100%100%0%15, 16, 17, 18, 19
   module.go100%100%63.38%..., 84, 87, 88, 89
   genesis.go100%100%54.55%21, 22, 23, 24, 25
x/interchainquery/keeper
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
   abci.go100%100%92.68%58, 59, 60
   queries.go100%100%98%67
   msg_server.go100%100%55.74%..., 76, 79, 87, 88
   keeper.go100%100%67.59%..., 43, 66, 67, 89
x/interchainquery/types
   keys.go100%100%0%22, 23, 24
   genesis.go100%100%63.64%15, 16, 17, 18
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   msgs.go100%100%54.17%..., 39, 45, 46, 47
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
   codec.go100%100%100%
x/oracle/keeper
   genesis.go100%100%93.33%..., 34, 43, 52, 63
   utils.go100%100%77.78%10, 9
   msg_server.go100%100%75.83%..., 81, 82, 85, 86
   reward.go100%100%91.67%14, 15, 72, 88
   params.go100%100%68.89%..., 75, 79, 80, 81
   keeper.go100%100%93.45%..., 47, 68, 69, 70
   tally.go100%100%93.55%..., 113, 114, 60, 61
   grpc_query.go100%100%15.29%..., 96, 97, 98, 99
   slash.go100%100%97.44%41
   alias_functions.go100%100%100%
   ballot.go100%100%100%
x/oracle/types
   genesis.go100%100%66.67%..., 23, 24, 25, 26
   ballot.go100%100%96.61%110, 111, 195, 196
   vote.go100%100%100%
   query.pb.gw.go100%100%0%..., 95, 97, 98, 99
   keys.go100%100%0%..., 52, 53, 54, 55
   genesis.pb.go100%100%0.93%..., 993, 994, 998, 999
   params.go100%100%88.59%..., 296, 297, 298, 300
   tx.pb.go100%100%0.90%..., 993, 994, 996, 999
   denom.go100%100%100%
   msgs.go100%100%76.19%..., 37, 54, 55, 90
   hash.go100%100%68.42%..., 65, 66, 68, 69
   codec.go100%100%52.38%..., 45, 46, 47, 48
   oracle.pb.go100%100%0.76%..., 995, 996, 997, 998
   query.pb.go100%100%0.83%..., 969, 97, 98, 99

@github-actions
Copy link

Coverage after merging ajeet/sdk-v47 into master

18.75%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   genesis.go100%100%0%19, 20, 21
   encoding.go100%100%100%
   test_suite.go100%100%0%..., 52, 53, 54, 56
   genesis_account.go100%100%100%
   app.go100%100%84.93%..., 855, 858, 859, 860
   export.go100%100%13.43%..., 96, 97, 98, 99
   test_helpers.go100%100%18.01%..., 53, 54, 55, 56
simapp/simd/cmd
   root.go100%100%80.37%..., 68, 69, 72, 73
   testnet.go100%100%69.54%..., 533, 534, 91, 92
   genaccounts.go100%100%71.54%..., 95, 96, 97, 98
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
x/epochs/keeper
   keeper.go100%100%92.86%30
   hooks.go100%100%100%
   genesis.go100%100%90.91%14
   abci.go100%100%100%
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
   epoch.go100%100%85.71%..., 25, 61, 87, 92
x/epochs/types
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   genesis.pb.go100%100%28.80%..., 96, 97, 98, 99
   genesis.go100%100%59.18%..., 57, 58, 61, 62
   hooks.go100%100%100%
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
x/halving/simulation
   genesis.go100%100%70%17, 18, 19
x/halving/types
   params.go100%100%85.29%24, 25, 26, 44, 45
   genesis.go100%100%86.67%25, 26
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
x/interchainquery
   genesis.go100%100%54.55%21, 22, 23, 24, 25
   handler.go100%100%0%15, 16, 17, 18, 19
   module.go100%100%63.38%..., 84, 87, 88, 89
x/interchainquery/keeper
   queries.go100%100%98%67
   keeper.go100%100%67.59%..., 43, 66, 67, 89
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
   msg_server.go100%100%55.74%..., 76, 79, 87, 88
   abci.go100%100%92.68%58, 59, 60
x/interchainquery/types
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999
   msgs.go100%100%54.17%..., 39, 45, 46, 47
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
   keys.go100%100%0%22, 23, 24
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
   codec.go100%100%100%
   genesis.go100%100%63.64%15, 16, 17, 18
x/oracle/keeper
   msg_server.go100%100%75.83%..., 81, 82, 85, 86
   slash.go100%100%97.44%41
   reward.go100%100%91.67%14, 15, 72, 88
   tally.go100%100%93.55%..., 113, 114, 60, 61
   utils.go100%100%77.78%10, 9
   params.go100%100%68.89%..., 75, 79, 80, 81
   alias_functions.go100%100%100%
   keeper.go100%100%93.45%..., 47, 68, 69, 70
   genesis.go100%100%93.33%..., 34, 43, 52, 63
   grpc_query.go100%100%15.29%..., 96, 97, 98, 99
   ballot.go100%100%100%
x/oracle/types
   denom.go100%100%100%
   ballot.go100%100%96.61%110, 111, 195, 196
   keys.go100%100%0%..., 52, 53, 54, 55
   vote.go100%100%100%
   query.pb.go100%100%0.83%..., 969, 97, 98, 99
   msgs.go100%100%76.19%..., 37, 54, 55, 90
   query.pb.gw.go100%100%0%..., 95, 97, 98, 99
   hash.go100%100%68.42%..., 65, 66, 68, 69
   tx.pb.go100%100%0.90%..., 993, 994, 996, 999
   params.go100%100%88.59%..., 296, 297, 298, 300
   oracle.pb.go100%100%0.76%..., 995, 996, 997, 998
   codec.go100%100%52.38%..., 45, 46, 47, 48
   genesis.go100%100%66.67%..., 23, 24, 25, 26
   genesis.pb.go100%100%0.93%..., 993, 994, 998, 999

@github-actions
Copy link

Coverage after merging ajeet/sdk-v47 into master

18.75%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   test_suite.go100%100%0%..., 52, 53, 54, 56
   genesis_account.go100%100%100%
   export.go100%100%13.43%..., 96, 97, 98, 99
   encoding.go100%100%100%
   genesis.go100%100%0%19, 20, 21
   app.go100%100%84.93%..., 855, 858, 859, 860
   test_helpers.go100%100%18.01%..., 53, 54, 55, 56
simapp/simd/cmd
   genaccounts.go100%100%71.54%..., 95, 96, 97, 98
   root.go100%100%80.37%..., 68, 69, 72, 73
   testnet.go100%100%69.54%..., 533, 534, 91, 92
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
x/epochs/keeper
   keeper.go100%100%92.86%30
   epoch.go100%100%85.71%..., 25, 61, 87, 92
   genesis.go100%100%90.91%14
   abci.go100%100%100%
   hooks.go100%100%100%
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
x/epochs/types
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
   genesis.pb.go100%100%28.80%..., 96, 97, 98, 99
   genesis.go100%100%59.18%..., 57, 58, 61, 62
   hooks.go100%100%100%
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
x/halving/simulation
   genesis.go100%100%70%17, 18, 19
x/halving/types
   genesis.go100%100%86.67%25, 26
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
   params.go100%100%85.29%24, 25, 26, 44, 45
x/interchainquery
   module.go100%100%63.38%..., 84, 87, 88, 89
   handler.go100%100%0%15, 16, 17, 18, 19
   genesis.go100%100%54.55%21, 22, 23, 24, 25
x/interchainquery/keeper
   abci.go100%100%92.68%58, 59, 60
   queries.go100%100%98%67
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
   keeper.go100%100%67.59%..., 43, 66, 67, 89
   msg_server.go100%100%55.74%..., 76, 79, 87, 88
x/interchainquery/types
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   msgs.go100%100%54.17%..., 39, 45, 46, 47
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
   codec.go100%100%100%
   genesis.go100%100%63.64%15, 16, 17, 18
   keys.go100%100%0%22, 23, 24
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
x/oracle/keeper
   keeper.go100%100%93.45%..., 47, 68, 69, 70
   genesis.go100%100%93.33%..., 34, 43, 52, 63
   msg_server.go100%100%75.83%..., 81, 82, 85, 86
   params.go100%100%68.89%..., 75, 79, 80, 81
   alias_functions.go100%100%100%
   reward.go100%100%91.67%14, 15, 72, 88
   slash.go100%100%97.44%41
   ballot.go100%100%100%
   tally.go100%100%93.55%..., 113, 114, 60, 61
   utils.go100%100%77.78%10, 9
   grpc_query.go100%100%15.29%..., 96, 97, 98, 99
x/oracle/types
   ballot.go100%100%96.61%110, 111, 195, 196
   genesis.go100%100%66.67%..., 23, 24, 25, 26
   oracle.pb.go100%100%0.76%..., 995, 996, 997, 998
   genesis.pb.go100%100%0.93%..., 993, 994, 998, 999
   denom.go100%100%100%
   params.go100%100%88.59%..., 296, 297, 298, 300
   query.pb.gw.go100%100%0%..., 95, 97, 98, 99
   hash.go100%100%68.42%..., 65, 66, 68, 69
   vote.go100%100%100%
   keys.go100%100%0%..., 52, 53, 54, 55
   query.pb.go100%100%0.83%..., 969, 97, 98, 99
   msgs.go100%100%76.19%..., 37, 54, 55, 90
   tx.pb.go100%100%0.90%..., 993, 994, 996, 999
   codec.go100%100%52.38%..., 45, 46, 47, 48

xlab
xlab previously approved these changes May 24, 2023
proto/buf.yaml Outdated Show resolved Hide resolved
proto/buf.yaml Outdated Show resolved Hide resolved
simapp/app_test.go Show resolved Hide resolved
@github-actions
Copy link

Coverage after merging ajeet/sdk-v47 into master

18.75%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   genesis_account.go100%100%100%
   test_suite.go100%100%0%..., 52, 53, 54, 56
   app.go100%100%84.93%..., 855, 858, 859, 860
   test_helpers.go100%100%18.01%..., 53, 54, 55, 56
   genesis.go100%100%0%19, 20, 21
   export.go100%100%13.43%..., 96, 97, 98, 99
   encoding.go100%100%100%
simapp/simd/cmd
   root.go100%100%80.37%..., 68, 69, 72, 73
   testnet.go100%100%69.54%..., 533, 534, 91, 92
   genaccounts.go100%100%71.54%..., 95, 96, 97, 98
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
x/epochs/keeper
   genesis.go100%100%90.91%14
   abci.go100%100%100%
   hooks.go100%100%100%
   epoch.go100%100%85.71%..., 25, 61, 87, 92
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
   keeper.go100%100%92.86%30
x/epochs/types
   genesis.pb.go100%100%28.80%..., 96, 97, 98, 99
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
   genesis.go100%100%59.18%..., 57, 58, 61, 62
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   hooks.go100%100%100%
x/halving/simulation
   genesis.go100%100%70%17, 18, 19
x/halving/types
   params.go100%100%85.29%24, 25, 26, 44, 45
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   genesis.go100%100%86.67%25, 26
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
x/interchainquery
   genesis.go100%100%54.55%21, 22, 23, 24, 25
   handler.go100%100%0%15, 16, 17, 18, 19
   module.go100%100%63.38%..., 84, 87, 88, 89
x/interchainquery/keeper
   abci.go100%100%92.68%58, 59, 60
   keeper.go100%100%67.59%..., 43, 66, 67, 89
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
   queries.go100%100%98%67
   msg_server.go100%100%55.74%..., 76, 79, 87, 88
x/interchainquery/types
   keys.go100%100%0%22, 23, 24
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
   genesis.go100%100%63.64%15, 16, 17, 18
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
   msgs.go100%100%54.17%..., 39, 45, 46, 47
   codec.go100%100%100%
x/oracle/keeper
   alias_functions.go100%100%100%
   ballot.go100%100%100%
   msg_server.go100%100%75.83%..., 81, 82, 85, 86
   grpc_query.go100%100%15.29%..., 96, 97, 98, 99
   params.go100%100%68.89%..., 75, 79, 80, 81
   reward.go100%100%91.67%14, 15, 72, 88
   utils.go100%100%77.78%10, 9
   slash.go100%100%97.44%41
   tally.go100%100%93.55%..., 113, 114, 60, 61
   keeper.go100%100%93.45%..., 47, 68, 69, 70
   genesis.go100%100%93.33%..., 34, 43, 52, 63
x/oracle/types
   query.pb.go100%100%0.83%..., 969, 97, 98, 99
   hash.go100%100%68.42%..., 65, 66, 68, 69
   ballot.go100%100%96.61%110, 111, 195, 196
   msgs.go100%100%76.19%..., 37, 54, 55, 90
   params.go100%100%88.59%..., 296, 297, 298, 300
   denom.go100%100%100%
   oracle.pb.go100%100%0.76%..., 995, 996, 997, 998
   vote.go100%100%100%
   genesis.pb.go100%100%0.93%..., 993, 994, 998, 999
   genesis.go100%100%66.67%..., 23, 24, 25, 26
   tx.pb.go100%100%0.90%..., 993, 994, 996, 999
   codec.go100%100%52.38%..., 45, 46, 47, 48
   keys.go100%100%0%..., 52, 53, 54, 55
   query.pb.gw.go100%100%0%..., 95, 97, 98, 99

@github-actions
Copy link

Coverage after merging ajeet/sdk-v47 into master

18.75%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   export.go100%100%13.43%..., 96, 97, 98, 99
   genesis_account.go100%100%100%
   app.go100%100%84.93%..., 855, 858, 859, 860
   encoding.go100%100%100%
   test_suite.go100%100%0%..., 52, 53, 54, 56
   genesis.go100%100%0%19, 20, 21
   test_helpers.go100%100%18.01%..., 53, 54, 55, 56
simapp/simd/cmd
   root.go100%100%80.37%..., 68, 69, 72, 73
   testnet.go100%100%69.54%..., 533, 534, 91, 92
   genaccounts.go100%100%71.54%..., 95, 96, 97, 98
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
x/epochs/keeper
   hooks.go100%100%100%
   epoch.go100%100%85.71%..., 25, 61, 87, 92
   abci.go100%100%100%
   keeper.go100%100%92.86%30
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
   genesis.go100%100%90.91%14
x/epochs/types
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
   genesis.go100%100%59.18%..., 57, 58, 61, 62
   genesis.pb.go100%100%28.80%..., 96, 97, 98, 99
   hooks.go100%100%100%
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
x/halving/simulation
   genesis.go100%100%70%17, 18, 19
x/halving/types
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
   genesis.go100%100%86.67%25, 26
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
   params.go100%100%85.29%24, 25, 26, 44, 45
x/interchainquery
   handler.go100%100%0%15, 16, 17, 18, 19
   module.go100%100%63.38%..., 84, 87, 88, 89
   genesis.go100%100%54.55%21, 22, 23, 24, 25
x/interchainquery/keeper
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
   keeper.go100%100%67.59%..., 43, 66, 67, 89
   abci.go100%100%92.68%58, 59, 60
   msg_server.go100%100%55.74%..., 76, 79, 87, 88
   queries.go100%100%98%67
x/interchainquery/types
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999
   genesis.go100%100%63.64%15, 16, 17, 18
   msgs.go100%100%54.17%..., 39, 45, 46, 47
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   keys.go100%100%0%22, 23, 24
   codec.go100%100%100%
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
x/oracle/keeper
   genesis.go100%100%93.33%..., 34, 43, 52, 63
   keeper.go100%100%93.45%..., 47, 68, 69, 70
   utils.go100%100%77.78%10, 9
   alias_functions.go100%100%100%
   slash.go100%100%97.44%41
   ballot.go100%100%100%
   params.go100%100%68.89%..., 75, 79, 80, 81
   reward.go100%100%91.67%14, 15, 72, 88
   tally.go100%100%93.55%..., 113, 114, 60, 61
   grpc_query.go100%100%15.29%..., 96, 97, 98, 99
   msg_server.go100%100%75.83%..., 81, 82, 85, 86
x/oracle/types
   genesis.pb.go100%100%0.93%..., 993, 994, 998, 999
   keys.go100%100%0%..., 52, 53, 54, 55
   ballot.go100%100%96.61%110, 111, 195, 196
   genesis.go100%100%66.67%..., 23, 24, 25, 26
   query.pb.gw.go100%100%0%..., 95, 97, 98, 99
   codec.go100%100%52.38%..., 45, 46, 47, 48
   tx.pb.go100%100%0.90%..., 993, 994, 996, 999
   denom.go100%100%100%
   hash.go100%100%68.42%..., 65, 66, 68, 69
   query.pb.go100%100%0.83%..., 969, 97, 98, 99
   vote.go100%100%100%
   oracle.pb.go100%100%0.76%..., 995, 996, 997, 998
   params.go100%100%88.59%..., 296, 297, 298, 300
   msgs.go100%100%76.19%..., 37, 54, 55, 90

@github-actions
Copy link

Coverage after merging ajeet/sdk-v47 into master

18.75%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   app.go100%100%84.93%..., 855, 858, 859, 860
   test_helpers.go100%100%18.01%..., 53, 54, 55, 56
   export.go100%100%13.43%..., 96, 97, 98, 99
   encoding.go100%100%100%
   genesis.go100%100%0%19, 20, 21
   genesis_account.go100%100%100%
   test_suite.go100%100%0%..., 52, 53, 54, 56
simapp/simd/cmd
   genaccounts.go100%100%71.54%..., 95, 96, 97, 98
   root.go100%100%80.37%..., 68, 69, 72, 73
   testnet.go100%100%69.54%..., 533, 534, 91, 92
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
x/epochs/keeper
   abci.go100%100%100%
   hooks.go100%100%100%
   epoch.go100%100%85.71%..., 25, 61, 87, 92
   genesis.go100%100%90.91%14
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
   keeper.go100%100%92.86%30
x/epochs/types
   genesis.pb.go100%100%28.80%..., 96, 97, 98, 99
   hooks.go100%100%100%
   genesis.go100%100%59.18%..., 57, 58, 61, 62
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
x/halving/simulation
   genesis.go100%100%70%17, 18, 19
x/halving/types
   params.go100%100%85.29%24, 25, 26, 44, 45
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   genesis.go100%100%86.67%25, 26
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
x/interchainquery
   genesis.go100%100%54.55%21, 22, 23, 24, 25
   module.go100%100%63.38%..., 84, 87, 88, 89
   handler.go100%100%0%15, 16, 17, 18, 19
x/interchainquery/keeper
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
   keeper.go100%100%67.59%..., 43, 66, 67, 89
   abci.go100%100%92.68%58, 59, 60
   queries.go100%100%98%67
   msg_server.go100%100%55.74%..., 76, 79, 87, 88
x/interchainquery/types
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999
   keys.go100%100%0%22, 23, 24
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
   genesis.go100%100%63.64%15, 16, 17, 18
   codec.go100%100%100%
   msgs.go100%100%54.17%..., 39, 45, 46, 47
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
x/oracle/keeper
   grpc_query.go100%100%15.29%..., 96, 97, 98, 99
   reward.go100%100%91.67%14, 15, 72, 88
   params.go100%100%68.89%..., 75, 79, 80, 81
   genesis.go100%100%93.33%..., 34, 43, 52, 63
   keeper.go100%100%93.45%..., 47, 68, 69, 70
   alias_functions.go100%100%100%
   utils.go100%100%77.78%10, 9
   msg_server.go100%100%75.83%..., 81, 82, 85, 86
   slash.go100%100%97.44%41
   ballot.go100%100%100%
   tally.go100%100%93.55%..., 113, 114, 60, 61
x/oracle/types
   msgs.go100%100%76.19%..., 37, 54, 55, 90
   ballot.go100%100%96.61%110, 111, 195, 196
   genesis.pb.go100%100%0.93%..., 993, 994, 998, 999
   denom.go100%100%100%
   genesis.go100%100%66.67%..., 23, 24, 25, 26
   codec.go100%100%52.38%..., 45, 46, 47, 48
   query.pb.gw.go100%100%0%..., 95, 97, 98, 99
   params.go100%100%88.59%..., 296, 297, 298, 300
   tx.pb.go100%100%0.90%..., 993, 994, 996, 999
   hash.go100%100%68.42%..., 65, 66, 68, 69
   query.pb.go100%100%0.83%..., 969, 97, 98, 99
   keys.go100%100%0%..., 52, 53, 54, 55
   oracle.pb.go100%100%0.76%..., 995, 996, 997, 998
   vote.go100%100%100%

@xlab xlab merged commit a30cdc5 into master Jun 20, 2023
3 checks passed
@xlab xlab deleted the ajeet/sdk-v47 branch June 20, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants