Prepare v3: IBC Wasm Hooks, PFM and Simapp rewrite #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 26, 2023 15:36
Commit 1e56cc620a17e0b5debb8228896aa44b6421a723
This ignores app_v2 with deepinject which is not ready to be used with IBC and other modules, for now we are sticking to app_v1 that is similar to what we had there. In this commit the app is replaced, but no custom modules from persistence added.
xlab
changed the title
added 9 commits
June 16, 2023 03:22
The test spawns two nodes and IBC relayer, deploys WASM contract and runs few IBC transfers resulting in hooks triggering the counter updates in the contract. This is a desperate measure to test it out, ideally we want to write integration test in Go (see ibc middleware test), however, the infra used by original implementation expects ibc/v4 and it's time consuming to properly re-implement it for ibc/v4 and sdk v47. For now we're good with this E2E test. Credit for the test goes to Terra, however it was refactored to accomodate sdk v47.
This actually needs to be LSM-enabled fork that imports our SDK and IBC repos.
Warn: the scope is not clear now, for now includes Auction mempool and their custom Ante decorator.
xlab
requested review from
ajeet97 and
puneet2019
and removed request for
ajeet97
xlab
changed the title
|
chore: move wasmbindings from persistenceCore |
|
ibchooker has been removed from wiring |
feat: add POB module from skip-mev to simapp
|
Coverage after merging f/max/ibc-hooks into master
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
xlab
changed the title
|
Coverage after merging f/max/ibc-hooks into master
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging f/max/ibc-hooks into master
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This PR lost its reason:
Only useful part there is:The new simapp code from See #405 |
xlab
pushed a commit
that referenced
this pull request
Jul 13, 2023
This ignores app_v2 with deepinject which is not ready to be used with IBC and other modules, for now we are sticking to app_v1 that is similar to what we had there. The commit is a merged version from superceded PR #403
This was referenced Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP description.
To keep summary: