Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement custom events suggestions #4092

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Implement custom events suggestions #4092

wants to merge 2 commits into from

Conversation

zoldar
Copy link
Contributor

@zoldar zoldar commented May 9, 2024

Changes

Depends on #4033

Add support for suggesting events when defining custom goal events.

TODO

  • fix modal not resetting combobox state when it should

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@RobertJoonas RobertJoonas mentioned this pull request May 9, 2024
Merged
3 tasks
@zoldar zoldar force-pushed the custom-events-suggestions branch 3 times, most recently from 6f8f166 to ad215cf Compare May 14, 2024 07:25
@zoldar zoldar force-pushed the custom-events-suggestions branch from ad215cf to 379d02a Compare May 20, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zoldar