Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unselecting filter from filter modal #4109

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix unselecting filter from filter modal #4109

merged 1 commit into from
May 21, 2024

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented May 16, 2024

Quick fix for a frontend bug. Explanation: https://cap.link/4sh44v2japssn2w

@metmarkosaric
Copy link
Contributor

@ukutaht just an fyi that the video link goes to https://cap.so front page

zoldar
zoldar approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@zoldar zoldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reproduced the problem locally and confirmed the fix addresses it.

For reference, here's the recording of how the issue manifests:

filter_issue.webm

@zoldar zoldar merged commit b2860d1 into master May 21, 2024
7 checks passed
@ukutaht ukutaht deleted the fix-unselecting-filter branch May 21, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoldar zoldar zoldar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ukutaht @metmarkosaric @zoldar