Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert map JSON data to C instead of asm #1736

Open
GriffinRichards opened this issue Aug 12, 2022 · 0 comments
Open

Convert map JSON data to C instead of asm #1736

GriffinRichards opened this issue Aug 12, 2022 · 0 comments

Comments

@GriffinRichards
Copy link
Member

GriffinRichards commented Aug 12, 2022

Putting this here so I don't forget (or in case someone else takes an interest):

At the moment, the data in data/maps.s and data/map_events.s is assembly data that gets written by mapjson using the JSON data for maps/layouts. This is facilitated with some assembly macros in asm/macros/map.inc, which users then need to keep in sync with their corresponding structs in C if they make any changes to them. It would require less management from users if mapjson (or jsonproc) would convert the JSON data to C instead.

The same should also be done for data/tilesets.s at some point, but this data is currently read/written by Porymap directly rather than as JSON data, so this would be a breaking change.

EDIT: The latter point has been handled by #1796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant